Fix: social links registration logic. #17494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
the
[Type] Bug
|
Looks like there are some failing tests, otherwise, this fixes the issue for me. |
jorgefilipecosta
force-pushed
the
fix/social-links-registrarion-logic
branch
from
4ed9cc3
to
0db3b70
Compare
Hi @youknowriad, I think the failing test was a lint error and I fixed it meanwhile. |
youknowriad
approved these changes
Sep 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Blocks may be registered on WordPress core and Gutenberg. When we load a block in Gutenberg we need to unregister the equivalent core block to make sure the one implemented on the plugin is loaded.
This PR fixes this logic to work with the social link(s) blocks that register multiple blocks in a single PHP file.
How has this been tested?
Run the Gutenberg plugin on WordPress develop trunk and verify there are no errors saying social link blocks were registered multiple times.