Select the first cell of the table block when initialised #1755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a worthwhile change, but it also needs to be fixed in TinyMCE. It's not difficult to select a block without focusing any of its elements. |
|
Code looks reasonable; I will test this tomorrow. |
nylen
changed the title
|
Thanks for the fix. |
|
@nylen @EphoxJames There is a regression here I think. On the Gutenberg Demo page, after the page loads the cursor gets put onto the table halfway down the page:
|
Tug
pushed a commit
that referenced
this pull request
Jan 16, 2020
Co-authored-by: Drapich Piotr <drapich.piotr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works around the bug that causes #1751 since it could be a while before I get it fixed in TinyMCE.