-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a shared sample post content #178
Conversation
A few observations for how the single instance prototype will have trouble supporting this:
I think both of these worries could be overcome without too much trouble. To the text itself:
All this being said, I think it's good to work from a common base. I'd be fine with merging this more-or-less as-is, perhaps with consideration of a few of the above points on the text, then we can continue to iterate and work through the challenges highlighted above. |
Ideally support links, currently escaped if tried to derive as HTML
To address a few of the points above, I simplified the markup (removed aligned paragraph, full-bleed image) and added a "complex" example: an oEmbed link. This one seems like it'll be challenging to support in a static mockup, but I figure we can keep it for now as an ideal. The TinyMCE-per-block prototype will ignore the unsupported type anyways. Updates also include a link in the quote citation, which I think we should support (that's how it's shown in the original text). It's not linked yet in the prototype, but 9473413 at least avoids the HTML from being shown as escaped. I also reformatted the content into a joined array of strings to make it slightly easier to maintain since I'll assume we'll want to make future revisions. |
I also observed that, when attempting to |
Adding a shared sample post content
…after-block-splitting Fix validation after block splitting
Adding a sample post content to be used by the two technical prototypes.