Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MediaUploadButton autoOpen prop #1784

Merged
merged 1 commit into from
Jul 7, 2017
Merged

Conversation

aduth
Copy link
Member

@aduth aduth commented Jul 7, 2017

This pull request seeks to remove the autoOpen prop from the MediaUploadButton component, the intention being:

  • Per suggestion from @mtias , removing automatic modal display as the default behavior, requiring the user to choose images (or in the future, drop images) explicitly
  • To resolve a bug where the media modal is shown immediately when opening the demo screen

Testing instructions:

Verify that navigating to the Gutenberg > Demo screen does not display a modal immediately.

Verify that inserting a new image block does not display the media modal immediately, but functionality is otherwise unaffected.

@aduth aduth added the [Feature] Blocks Overall functionality of blocks label Jul 7, 2017
@aduth aduth requested a review from mtias July 7, 2017 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants