Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storybook: Add stories for Checkbox control component #17891

Merged
merged 14 commits into from
Oct 16, 2019
Merged

Storybook: Add stories for Checkbox control component #17891

merged 14 commits into from
Oct 16, 2019

Commits on Oct 16, 2019

  1. Add checkbox control stories for Storybook

    @mkaz
    mkaz committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    7291d94 View commit details
    Browse the repository at this point in the history

  2. Update README example to match story, useState

    @mkaz
    mkaz committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    98fa807 View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    👍

Co-Authored-By: Enrique Piqueras <epiqueras@users.noreply.github.com>
    @mkaz @epiqueras
    mkaz and epiqueras committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    aadf374 View commit details
    Browse the repository at this point in the history

  4. Update story to match README

    @mkaz
    mkaz committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    bcf27f1 View commit details
    Browse the repository at this point in the history

  5. Add variants for heading, label, help

    @mkaz
    mkaz committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    a7ab3c5 View commit details
    Browse the repository at this point in the history

  6. Update packages/components/src/checkbox-control/README.md 

    Co-Authored-By: Grzegorz (Greg) Ziółkowski <grzegorz@gziolo.pl>
    @mkaz @gziolo
    mkaz and gziolo committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    df5d50f View commit details
    Browse the repository at this point in the history

  7. Add Knobs addon to Storybook

    @mkaz
    mkaz committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    506de84 View commit details
    Browse the repository at this point in the history

  8. Move storybook addon to dev-dependencies

    @mkaz
    mkaz committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    c8f128a View commit details
    Browse the repository at this point in the history

  9. Solve lint dependency by excluding stories, dont need in package.json

    @mkaz
    mkaz committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    9f1b5cc View commit details
    Browse the repository at this point in the history

  10. Apply suggestions from code review 

    Co-Authored-By: Enrique Piqueras <epiqueras@users.noreply.github.com>
    @mkaz @epiqueras
    mkaz and epiqueras committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    b8fdd69 View commit details
    Browse the repository at this point in the history

  11. Update with story level decorators

    @mkaz
    mkaz committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    dafbed6 View commit details
    Browse the repository at this point in the history

  12. Switch back to global withKnobs, per story not working

    @mkaz
    mkaz committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    1583774 View commit details
    Browse the repository at this point in the history

  13. Change the name of the example in ChecboxControl story

    @gziolo
    gziolo authored Oct 16, 2019
    Configuration menu
    Copy the full SHA
    cd84a53 View commit details
    Browse the repository at this point in the history

  14. Try with the uppercase name of the component exported from stories

    @gziolo
    gziolo authored Oct 16, 2019
    Configuration menu
    Copy the full SHA
    bbcd3bf View commit details
    Browse the repository at this point in the history