-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mobile Web: Ensure that sidebar is closed on the first visit #17902
Mobile Web: Ensure that sidebar is closed on the first visit #17902
Conversation
The updated e2e test fails as expected without the production code updated. See https://travis-ci.com/WordPress/gutenberg/jobs/244637978#L1025:
|
e78d12d should resolve the issue. @nerrad - I figured out this is also related to the changes applied in #17712 so I would appreciate your review. We should ensure sidebar plugins do not get auto-closed when opened on smaller screens. I tested it myself and it works fine. We also have e2e tests that cover that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixes the issue for me.
Ack! Sorry for not catching this in my review of #17712 😓 |
* Mobile Web: Ensure that sidebar is closed on the first visit * Mobile Web: Ensure that sidebar is closed on the first visit
Description
Related to #17712.
Fixes #17341.
Fixes #17708.
I still need to add a proper fix, for the time being, I updated the test to catch this bug.
Steps to reproduce
Add New Post
page.With the fix applied Sidebar shouldn't cover the screen, it should be closed by default.
How has this been tested?
I updated e2e tests to ensure they catch this issue in the future in 4c68cb2.
They should all pas with:
npm run test-e2e