Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NavigationMenu: <LinkControl /> integration. #18062

Merged
merged 39 commits into from
Nov 6, 2019
Merged

NavigationMenu: <LinkControl /> integration. #18062

merged 39 commits into from
Nov 6, 2019
+168 −82

Commits on Nov 6, 2019

  1. link-control: doc

    @retrofox @talldan
    retrofox authored and talldan committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    9eaae16 View commit details
    Browse the repository at this point in the history

  2. navigation-menu-item: replace URLPopover by LinkControl

    @retrofox @talldan
    retrofox authored and talldan committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    b93b07a View commit details
    Browse the repository at this point in the history

  3. navigation-menu: do not set link when onClose

    @retrofox @talldan
    retrofox authored and talldan committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    c52d92f View commit details
    Browse the repository at this point in the history

  4. navigation-menu-item: ensuring hide popover once it closes

    @retrofox @talldan
    retrofox authored and talldan committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    33baef0 View commit details
    Browse the repository at this point in the history

  5. navigation-menu-item: anchor LinkControl at TextControl

    @retrofox @talldan
    retrofox authored and talldan committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    1cc27a2 View commit details
    Browse the repository at this point in the history

  6. navigation-menu-item: render external link

    @retrofox @talldan
    retrofox authored and talldan committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    28d446e View commit details
    Browse the repository at this point in the history

  7. navigation-menu-item: remove link object from attrs

    @retrofox @talldan
    retrofox authored and talldan committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    d32f027 View commit details
    Browse the repository at this point in the history

  8. navigation-menu-item: handing close link popover

    @retrofox @talldan
    retrofox authored and talldan committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    5eb1366 View commit details
    Browse the repository at this point in the history

  9. navigation-menu: set text color to external link

    @retrofox @talldan
    retrofox authored and talldan committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    9fa1562 View commit details
    Browse the repository at this point in the history

  10. navigation-menu: apply colors correctly in edition mode

    @retrofox @talldan
    retrofox authored and talldan committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    9616d76 View commit details
    Browse the repository at this point in the history

  11. navigation-menu-item: apply text color to external link

    @retrofox @talldan
    retrofox authored and talldan committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    35e88e8 View commit details
    Browse the repository at this point in the history

  12. fixing eslint errors/warnings

    @retrofox @talldan
    retrofox authored and talldan committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    2550320 View commit details
    Browse the repository at this point in the history

  13. fix camelcase warning flawlessly 

    props to @getdave
    @retrofox @talldan
    retrofox authored and talldan committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    fbfcec6 View commit details
    Browse the repository at this point in the history

  14. navigation-menu-item: set current link as null when it changes

    @retrofox @talldan
    retrofox authored and talldan committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    81bf11a View commit details
    Browse the repository at this point in the history

  15. link-control: doc fixes

    @retrofox @talldan
    retrofox authored and talldan committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    0d9637d View commit details
    Browse the repository at this point in the history

  16. Updates setting change handler to test for specific setting and value 

    Addresses #18062 (comment)
    @getdave @talldan
    getdave authored and talldan committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    154d2c7 View commit details
    Browse the repository at this point in the history

  17. Remove hyperlinks from nav item labels 

    Addresses #18062 (comment)
    @getdave @talldan
    getdave authored and talldan committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    ccccb5c View commit details
    Browse the repository at this point in the history

  18. Update attribute name 

    Addresses #18062 (comment)
    @getdave @talldan
    getdave authored and talldan committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    9a2d2fb View commit details
    Browse the repository at this point in the history

  19. Fix save output to handle new tab attribute 

    Addresses #18062 (comment)
    @getdave @talldan
    getdave authored and talldan committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    c712717 View commit details
    Browse the repository at this point in the history

  20. Update to simplify link update with default args 

    Addresses #18062 (comment)
    @getdave @talldan
    getdave authored and talldan committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    56536a1 View commit details
    Browse the repository at this point in the history

  21. Remove content accidentally re-added in merge of rebase

    @getdave @talldan
    getdave authored and talldan committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    0c965d8 View commit details
    Browse the repository at this point in the history

  22. navigation-menu-item: set title as label when it's empty

    @retrofox @talldan
    retrofox authored and talldan committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    80cb5e8 View commit details
    Browse the repository at this point in the history

  23. navigation-menu-item: open LinkControl when new item

    @retrofox @talldan
    retrofox authored and talldan committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    b9d2195 View commit details
    Browse the repository at this point in the history

  24. navigation-menu-item: new item workflow 

    open link control and show fake placeholder when it's a new iotem
    @retrofox @talldan
    retrofox authored and talldan committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    293bfb3 View commit details
    Browse the repository at this point in the history

  25. navigation-menu: rename state hook

    @retrofox @talldan
    retrofox authored and talldan committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    f6ebb92 View commit details
    Browse the repository at this point in the history

  26. navigation-menu-item: use camelCase for link ID

    @retrofox @talldan
    retrofox authored and talldan committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    3b4a3ed View commit details
    Browse the repository at this point in the history

  27. navigation-menu-item: set edit mode style

    @retrofox @talldan
    retrofox authored and talldan committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    468eff8 View commit details
    Browse the repository at this point in the history

  28. navigation-menu-item: remove fake placeholder stuff

    @retrofox @talldan
    retrofox authored and talldan committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    e85cf06 View commit details
    Browse the repository at this point in the history

  29. navigation-menu-item: no use effect to Initialize is open state

    @retrofox @talldan
    retrofox authored and talldan committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    7044c24 View commit details
    Browse the repository at this point in the history

  30. navigation-menu-item: remove unneeded setting state

    @retrofox @talldan
    retrofox authored and talldan committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    2dfa557 View commit details
    Browse the repository at this point in the history

  31. navigation-menu-item: move link control callback outside of the compo… 

    …nent rendering
    @retrofox @talldan
    retrofox authored and talldan committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    c063034 View commit details
    Browse the repository at this point in the history

  32. navigation-menu-item: simplify closing linkcontrol 

    It adds a hacky solution to deal with both events that happen at the
same time: LinkControl.onClose and ToolbatButton.onClick, removing the
useState ussage in favor adding a setTimeout call.
    @retrofox @talldan
    retrofox authored and talldan committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    e1b64e4 View commit details
    Browse the repository at this point in the history

  33. navigation-menu: fixing eslint errors

    @retrofox @talldan
    retrofox authored and talldan committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    b77c663 View commit details
    Browse the repository at this point in the history

  34. Update packages/block-library/src/navigation-menu-item/edit.js 

    Co-Authored-By: Daniel Richards <daniel.richards@automattic.com>
    @getdave @talldan
    getdave and talldan committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    b4ca8ca View commit details
    Browse the repository at this point in the history

  35. Update packages/block-library/src/navigation-menu-item/edit.js 

    Co-Authored-By: Daniel Richards <daniel.richards@automattic.com>
    @getdave @talldan
    getdave and talldan committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    cf3d2c8 View commit details
    Browse the repository at this point in the history

  36. Fixes bug where Link UI was visually divorced from target Menu Item 

    Addresses #18062 (comment)
    @getdave @talldan
    getdave authored and talldan committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    2c7b597 View commit details
    Browse the repository at this point in the history

  37. Updates to remove unwanted prop being passed to LinkControl 

    `fetchSearchSuggestions` seems to have been accidentally re-added. It’s not required.

Addresses #18062 (comment)
    @getdave @talldan
    getdave authored and talldan committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    15bf1b2 View commit details
    Browse the repository at this point in the history

  38. navigation-menu: remove destination attr

    @retrofox @talldan
    retrofox authored and talldan committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    f60ae05 View commit details
    Browse the repository at this point in the history

  39. navigation-menu-item: cleanup timer once unmount

    @retrofox @talldan
    retrofox authored and talldan committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    c34be01 View commit details
    Browse the repository at this point in the history