-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Storybook: Adds FormToggle component #18085
Conversation
@enejb Awesome! Thank you for creating this and helping out with Storybook! It looks good to me 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@enejb great work jumping into creating a story 🥇
I have a more general question in regards to using React hooks in the exports. I saw the same approach in the past and I see it in other PRs so I think we should clarify how we tackle it first.
@ItsJonQ My only issue with the Here's a screen shot of what it looks like in ScrollLock. |
@mkaz Oh dang! That's a bit of a bummer... :( |
Thanks for the reviews! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks for the refactor. Looks great now 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more thing which I discovered while testing:
We should add the label and it can be integrated with knobs, see:
const title = text( 'children', 'WordPress' ); |
or
const label = text( 'Label', 'Is author' ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a commit which formats file with Prettier.
Let's get it in and iterate. @enejb, thank you for doing your part :)
Description
Adds FormToggle component to storybook
How has this been tested?
Run
npm run design-system:dev
and confirm component shows up under Form ToggleClick on the toggle does it work as expected?
Screenshots
Types of changes
Storybook