Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom paragraph options for media-text #18284

Merged
merged 2 commits into from
Nov 7, 2019

Conversation

koke
Copy link
Contributor

@koke koke commented Nov 5, 2019

This will make the content part behave like the regular block appender

Fixes wordpress-mobile/gutenberg-mobile#1531

Note that I also removed the default fontSize: large since we are currently not displaying/supporting font sizes, and it could lead to unexpected surprises when publishing the content.

media-text-placeholder

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

This will make the content part behave like the regular block appender
@koke koke added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Nov 5, 2019
@koke koke requested a review from pinarol November 5, 2019 11:10
@pinarol
Copy link
Contributor

pinarol commented Nov 7, 2019

WPAndroid: Everything works as expected.

WPiOS:

I've spotted an interesting issue where the first text input inside media-text starts with lowercase:

mediaTextLayout3

When we remove its contents and type something again it starts to work as expected:

mediaTextLayout2

Any ideas why this could be happening?

@koke
Copy link
Contributor Author

koke commented Nov 7, 2019

I've spotted an interesting issue where the first text input inside media-text starts with lowercase:

That's being fixed in wordpress-mobile/gutenberg-mobile#1552 😅

Copy link
Contributor

@pinarol pinarol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification @koke Let's :shipit:

@koke koke merged commit a5c974b into master Nov 7, 2019
@koke koke deleted the rnmobile/fix-media-text-placeholder branch November 7, 2019 09:05
@youknowriad youknowriad added this to the Gutenberg 6.9 milestone Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace media-text placeholder with default
3 participants