[Monorepo] split gutenberg-mobile to 3 packages - bridge, editor, aztec #18509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dratwas
added
[Status] In Progress
gziolo
reviewed
Nov 26, 2019
gziolo
reviewed
Nov 26, 2019
gziolo
reviewed
Nov 26, 2019
There was a problem hiding this comment.
I would recommend going through all package.json files related to new packages and make sure that :
- they don't contain
devDependencies peerDependenciesaren't outdated or too strictscriptssections should be removed unless they need to be executed for the package- they are public for npm publishing
In addition, they pass npm run lint-pkg-json command.
It all might turn out to be challenging :)
gziolo
added
the
Mobile App - i.e. Android or iOS
|
Now I see that #18531 addresses most of the comments included here 🙃 |
|
This looks good so far, let's review it again after #18508 is merged and we rebase this one onto |
Tug
changed the base branch from
rnmobile/import-mobile
to
feat/import-gutenberg-mobile
Tug
force-pushed
the
rnmobile/import-mobile-split-packages
branch
from
7412c47
to
eb7cd47
Compare
6 tasks
Tug
pushed a commit
that referenced
this pull request
Jan 16, 2020
…ec (#18509) * split to 3 packages bridge, editor, aztec * rename gutenberg bridge to bridge and add @WordPress namespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a part of migration
gutenberg-mobiletogutenbergrepo. In this PR I splitgutenberg-mobileto 3 packages.@wordpress/react-native-editor- playground react-native app and bundle entrypoint@wordpress/react-native-gutenberg-bridge- module which starts react-native inside the client app (WP-iOS/Android) (Name will be changed in the next PR to@wordpress/react-native-gutenberg-bridgesince we don't want to have a package with the name that includesgutenbergin it)@wordpress/react-native-aztec- react-native-aztec moduleIn this PR I also removed
yarn.lockfilesHow has this been tested?
There is nothing to test at this stage.
Types of changes
Split
gutenberg-mobileto 3 packages.Checklist: