-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Monorepo] Fix iOS build #18566
[Monorepo] Fix iOS build #18566
Conversation
3cd469e
to
d7c54c9
Compare
Size Change: 0 B Total Size: 856 kB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
XCode wasn't able to launch the metro server though, is this something we can fix? I had the same problem for the android PR but sadly I figured this is due to a bug in a react-native script, might be the same bug actually
The script to start the packager is not present in the Xcode project. But it's also not present in gutenberg-mobile's Xcode project. Could it be that it didn't launch the metro server before as well? |
Most probably 👍 Anyway it's consistent with android's behavior! Let's ship, but please don't merge yourself, @hypest has to in order to retain the history! |
…squash' into rnmobile/import-mobile-fix-build-ios
Merging this with "merge commit" option on. |
Description
This is a part of migration gutenberg-mobile to gutenberg repo.
In this PR I fixed iOS build of
react-native-editor
example app. In order to do that, I had to change paths to linked libraries in the iOS project and change paths where we search for headers.I also changed
rn-cli.config.js
where I addedwatchFolders
field withnode_modules
from the root level and allpackages
and removedrn-cl-inside-gb.config.js
since it is not needed anymore.The last thing is the fix for
sass-transformer.js
and removingsass-transformer-inside-gb.js
How has this been tested?
npm run native bundle:ios
should create a JS bundlenpm run native ios
should start iOS example appScreenshots
Types of changes
Fix the iOS build in imported
react-native-editor
packageChecklist: