Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Monorepo] Fix iOS build #18566

Conversation

dratwas
Copy link
Contributor

@dratwas dratwas commented Nov 18, 2019

Description

This is a part of migration gutenberg-mobile to gutenberg repo.

In this PR I fixed iOS build of react-native-editor example app. In order to do that, I had to change paths to linked libraries in the iOS project and change paths where we search for headers.

I also changed rn-cli.config.js where I added watchFolders field with node_modules from the root level and all packages and removed rn-cl-inside-gb.config.js since it is not needed anymore.

The last thing is the fix for sass-transformer.js and removing sass-transformer-inside-gb.js

How has this been tested?

  • npm run native bundle:ios should create a JS bundle
  • npm run native ios should start iOS example app
  • app should work when running from xcode

Screenshots

Types of changes

Fix the iOS build in imported react-native-editor package

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR. .

@dratwas dratwas added [Status] In Progress Tracking issues with work in progress [Type] Technical Prototype Offers a technical exploration into an idea as an example of what's possible labels Nov 18, 2019
@dratwas dratwas mentioned this pull request Nov 20, 2019
21 tasks
@dratwas dratwas removed the [Status] In Progress Tracking issues with work in progress label Nov 20, 2019
@dratwas dratwas marked this pull request as ready for review November 20, 2019 10:07
@gziolo gziolo added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Nov 26, 2019
@ceyhun ceyhun self-assigned this Mar 24, 2020
@ceyhun ceyhun changed the base branch from rnmobile/import-mobile-lint to feat/import-gutenberg-mobile-no-squash March 26, 2020 14:51
@ceyhun ceyhun force-pushed the rnmobile/import-mobile-fix-build-ios branch from 3cd469e to d7c54c9 Compare March 26, 2020 14:53
@github-actions
Copy link

github-actions bot commented Mar 26, 2020

Size Change: 0 B

Total Size: 856 kB

ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 998 B 0 B
build/annotations/index.js 3.43 kB 0 B
build/api-fetch/index.js 3.39 kB 0 B
build/autop/index.js 2.58 kB 0 B
build/blob/index.js 620 B 0 B
build/block-directory/index.js 6.02 kB 0 B
build/block-directory/style-rtl.css 760 B 0 B
build/block-directory/style.css 760 B 0 B
build/block-editor/index.js 100 kB 0 B
build/block-editor/style-rtl.css 10.9 kB 0 B
build/block-editor/style.css 10.9 kB 0 B
build/block-library/editor-rtl.css 7.24 kB 0 B
build/block-library/editor.css 7.24 kB 0 B
build/block-library/index.js 110 kB 0 B
build/block-library/style-rtl.css 7.42 kB 0 B
build/block-library/style.css 7.43 kB 0 B
build/block-library/theme-rtl.css 669 B 0 B
build/block-library/theme.css 671 B 0 B
build/block-serialization-default-parser/index.js 1.65 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/blocks/index.js 57.5 kB 0 B
build/components/index.js 191 kB 0 B
build/components/style-rtl.css 15.8 kB 0 B
build/components/style.css 15.7 kB 0 B
build/compose/index.js 6.21 kB 0 B
build/core-data/index.js 10.6 kB 0 B
build/data-controls/index.js 1.04 kB 0 B
build/data/index.js 8.2 kB 0 B
build/date/index.js 5.37 kB 0 B
build/deprecated/index.js 771 B 0 B
build/dom-ready/index.js 568 B 0 B
build/dom/index.js 3.06 kB 0 B
build/edit-post/index.js 91.2 kB 0 B
build/edit-post/style-rtl.css 8.47 kB 0 B
build/edit-post/style.css 8.46 kB 0 B
build/edit-site/index.js 5.56 kB 0 B
build/edit-site/style-rtl.css 2.62 kB 0 B
build/edit-site/style.css 2.62 kB 0 B
build/edit-widgets/index.js 4.43 kB 0 B
build/edit-widgets/style-rtl.css 2.58 kB 0 B
build/edit-widgets/style.css 2.58 kB 0 B
build/editor/editor-styles-rtl.css 381 B 0 B
build/editor/editor-styles.css 382 B 0 B
build/editor/index.js 43.8 kB 0 B
build/editor/style-rtl.css 3.97 kB 0 B
build/editor/style.css 3.96 kB 0 B
build/element/index.js 4.44 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/index.js 6.95 kB 0 B
build/format-library/style-rtl.css 502 B 0 B
build/format-library/style.css 502 B 0 B
build/hooks/index.js 1.93 kB 0 B
build/html-entities/index.js 621 B 0 B
build/i18n/index.js 3.49 kB 0 B
build/is-shallow-equal/index.js 711 B 0 B
build/keyboard-shortcuts/index.js 2.3 kB 0 B
build/keycodes/index.js 1.69 kB 0 B
build/list-reusable-blocks/index.js 2.99 kB 0 B
build/list-reusable-blocks/style-rtl.css 226 B 0 B
build/list-reusable-blocks/style.css 226 B 0 B
build/media-utils/index.js 4.83 kB 0 B
build/notices/index.js 1.58 kB 0 B
build/nux/index.js 3.01 kB 0 B
build/nux/style-rtl.css 616 B 0 B
build/nux/style.css 613 B 0 B
build/plugins/index.js 2.54 kB 0 B
build/primitives/index.js 1.5 kB 0 B
build/priority-queue/index.js 780 B 0 B
build/redux-routine/index.js 2.83 kB 0 B
build/rich-text/index.js 14.4 kB 0 B
build/server-side-render/index.js 2.55 kB 0 B
build/shortcode/index.js 1.7 kB 0 B
build/token-list/index.js 1.27 kB 0 B
build/url/index.js 4.01 kB 0 B
build/viewport/index.js 1.61 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.18 kB 0 B

compressed-size-action

Copy link
Contributor

@Tug Tug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

XCode wasn't able to launch the metro server though, is this something we can fix? I had the same problem for the android PR but sadly I figured this is due to a bug in a react-native script, might be the same bug actually

packages/react-native-editor/package.json Show resolved Hide resolved
@ceyhun
Copy link
Member

ceyhun commented Mar 26, 2020

XCode wasn't able to launch the metro server though, is this something we can fix?

The script to start the packager is not present in the Xcode project. But it's also not present in gutenberg-mobile's Xcode project. Could it be that it didn't launch the metro server before as well?

@Tug
Copy link
Contributor

Tug commented Mar 26, 2020

Could it be that it didn't launch the metro server before as well?

Most probably 👍

Anyway it's consistent with android's behavior!

Let's ship, but please don't merge yourself, @hypest has to in order to retain the history!

ceyhun
ceyhun previously approved these changes Mar 26, 2020
@ceyhun ceyhun requested review from ceyhun and removed request for ceyhun March 26, 2020 17:53
…squash' into rnmobile/import-mobile-fix-build-ios
@hypest
Copy link
Contributor

hypest commented Mar 27, 2020

Merging this with "merge commit" option on.

@hypest hypest merged commit a7b7abf into feat/import-gutenberg-mobile-no-squash Mar 27, 2020
@hypest hypest deleted the rnmobile/import-mobile-fix-build-ios branch March 27, 2020 15:25
@Tug Tug mentioned this pull request Jun 5, 2020
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Technical Prototype Offers a technical exploration into an idea as an example of what's possible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants