Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for wp-env.json config file #18643

Merged
merged 2 commits into from
Nov 20, 2019
Merged

Add documentation for wp-env.json config file #18643

merged 2 commits into from
Nov 20, 2019

Conversation

noahtallen
Copy link
Member

Description

Added documentation for using the wp-env.json file. (See #18121).

How has this been tested?

n/a

Screenshots

n/a

Types of changes

Documentation

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR. .

@noahtallen noahtallen added the [Type] Developer Documentation Documentation for developers label Nov 20, 2019
@noahtallen noahtallen requested a review from epiqueras November 20, 2019 20:08
@noahtallen noahtallen self-assigned this Nov 20, 2019
@noahtallen noahtallen mentioned this pull request Nov 20, 2019
Merged
5 tasks
epiqueras
epiqueras requested changes Nov 20, 2019
View reviewed changes
packages/env/README.md Outdated Show resolved Hide resolved
packages/env/README.md Outdated Show resolved Hide resolved
packages/env/README.md Outdated Show resolved Hide resolved
packages/env/README.md Outdated Show resolved Hide resolved
packages/env/README.md Outdated Show resolved Hide resolved
packages/env/README.md Outdated Show resolved Hide resolved
@noahtallen @epiqueras
Clarify documentation
d1265c7 
Co-Authored-By: Enrique Piqueras <epiqueras@users.noreply.github.com>
@noahtallen
Copy link
Member Author

@epiqueras Those changes look good to me :)

@epiqueras epiqueras merged commit c4ba262 into master Nov 20, 2019
@epiqueras epiqueras deleted the add/docs-for-wp-env-config-file branch November 20, 2019 22:00
@youknowriad youknowriad added this to the Gutenberg 7.0 milestone Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epiqueras epiqueras epiqueras approved these changes

Assignees

@noahtallen noahtallen

Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Milestone
Gutenberg 7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@noahtallen @epiqueras @youknowriad