Writing flow: simplify & fix tabbing out of block #19312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
reviewed
Dec 23, 2019
| @@ -77,13 +77,23 @@ export function isNavigationCandidate( element, keyCode, hasModifier ) { | |||
| * Renders focus capturing areas to redirect focus to the selected block if not | |||
| * in Navigation mode. | |||
| */ | |||
| function FocusCapture( { selectedClientId, isReverse, containerRef } ) { | |||
| const FocusCapture = forwardRef( ( { | |||
There was a problem hiding this comment.
Things are becoming a little bit hard to follow for me. it would be good to clarify exactly what this component is for, its props...
There was a problem hiding this comment.
Sorry, I should be documenting better! I'll write something for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #19235, I added logic for tabbing to move focus before or after the block list if focus leaves the block. This adjusts part of it to avoid searching tabbables and based on elements outside
WritingFlow.It also fixes Storybook. The block editor currently errors if you tab out of it.
How has this been tested?
Screenshots
Types of changes
Checklist: