Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block table: allow tabbing away from the table. #1938

Merged
merged 1 commit into from
Jul 19, 2017

Conversation

afercia
Copy link
Contributor

@afercia afercia commented Jul 18, 2017

This PR sets the TinyMCE table plugin table_tab_navigation option to false to allow users to tab away from the table cells. Keyboard navigation through cells works with arrow keys only.

Worth noting, while working on this I've noticed sometimes it isn't possible to set focus on the table cells using a keyboard. Couldn't reproduce consistently though and I think it's something unrelated to this PR. I've also checked #1793 and #1751 but couldn't find any hint to investigate further.

Fixes #1839

@afercia afercia added the [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). label Jul 18, 2017
@afercia afercia requested review from aduth and BoardJames July 18, 2017 18:02
Copy link

@BoardJames BoardJames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me.

@afercia
Copy link
Contributor Author

afercia commented Jul 19, 2017

Thanks EphoxJames!

@afercia afercia merged commit 43d4a2f into master Jul 19, 2017
@afercia afercia deleted the update/table-block-tabbing-away branch July 19, 2017 07:06
Tug pushed a commit that referenced this pull request Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants