Block toolbar: fix hasMovers #19619
Merged
Block toolbar: fix hasMovers #19619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
force-pushed
the
fix/has-movers
branch
2 times, most recently
from
fd1ac4e
to
991d0a6
Compare
There was a problem hiding this comment.
Hi @ellatrix, this PR fixes the problem with hasMovers 👍
Additionally it removes the data- props from the contextual toolbar and breadcrumb and uses the popover instead.
Checking the code I did not found this removal, I'm missing something?
|
@jorgefilipecosta Ah, I decided to leave it out as it was causing test failures. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See #18173.
hasMovershas never worked for the top or mobile toolbar. Additionally, it also broke recently when the contextual block toolbar was moved out of the block tree.Additionally it removes the data- props from the contextual toolbar and breadcrumb and uses the popover instead.
How has this been tested?
Screenshots
Types of changes
Checklist: