Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use URL interface to validate URI #19819

Conversation

WunderBart
Copy link
Member

@WunderBart WunderBart commented Jan 22, 2020

Description

Replacing valid-url package with the whatwg-url (because IE11) for creating a URI validator. The polyfill is a better choice IMO, as it's much more versatile and later on (once we drop IE11 support) we could easily switch to the native implementation.

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR. .

@WunderBart
Copy link
Member Author

Closing in favor of #19871.

@WunderBart WunderBart closed this Feb 6, 2020
@WunderBart WunderBart deleted the try/improve-link-control-url-detection-with-url-interface branch February 6, 2020 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant