-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade react native to 0.62.2 #19950
Conversation
Size Change: 0 B Total Size: 1.14 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working great on iOS
I appreciate all the work here. It doesn’t look like an easy task to make the lock file play right with web and mobile |
Feel free to leave an exact version of the packages because it looks like the lock file gets 10 000 lines updated 🙁 you can remove last 2 commits that fail on Travis. I can help later today |
Thanks @gziolo ! |
3b4e850
to
1a0b17e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marecar3 can you test again with Gutenberg Mobile? From my end, it's ready to go 🚢
# Conflicts: # package-lock.json
@@ -65,6 +65,7 @@ const gpl2CompatibleLicenses = [ | |||
'(MIT AND BSD-3-Clause)', | |||
'(MIT AND Zlib)', | |||
'(CC-BY-4.0 AND MIT)', | |||
'0BSD', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0BSD is ISC without the requirement to maintain the copyright notice. It's about as close to public domain as you can get. While the FSF haven't commented on the compatibility of 0BSD, they have stated that ISC is GPL-compatible, which is enough for me.
@@ -65,6 +65,7 @@ const gpl2CompatibleLicenses = [ | |||
'(MIT AND BSD-3-Clause)', | |||
'(MIT AND Zlib)', | |||
'(CC-BY-4.0 AND MIT)', | |||
'0BSD', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0BSD is ISC without the requirement to maintain the copyright notice. It's about as close to public domain as you can get. While the FSF haven't commented on the compatibility of 0BSD, they have stated that ISC is GPL-compatible, which is enough for me.
# Conflicts: # package-lock.json
# Conflicts: # package-lock.json
# Conflicts: # package-lock.json # packages/react-native-editor/ios/Podfile.lock # packages/react-native-editor/package.json # packages/scripts/scripts/check-licenses.js
# Conflicts: # packages/react-native-editor/ios/Podfile.lock
# Conflicts: # packages/react-native-editor/ios/Podfile.lock # packages/react-native-editor/package.json
Closing in favor: Update RN to 0.63 PR #24872 |
Description
Related gutenberg-mobile PR: wordpress-mobile/gutenberg-mobile#2439
Checklist: