Avoid navigating outside the editor using the arrow keys #2004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Bug
ellatrix
reviewed
Jul 26, 2017
editor/modes/visual-editor/block.js
Outdated
| @@ -262,7 +262,7 @@ class VisualEditorBlock extends Component { | |||
| '*[tabindex]', | |||
| 'textarea', | |||
| 'input', | |||
| ].join( ',' ); | |||
| ].map( ( selector ) => `.editor-visual-editor ${ selector }` ).join( ',' ); | |||
There was a problem hiding this comment.
Should we make that a constant?
ellatrix
approved these changes
Jul 26, 2017
youknowriad
force-pushed
the
fix/arrow-navigation-outside-editor
branch
from
6065dcd
to
3ac6370
Compare
youknowriad
force-pushed
the
fix/arrow-navigation-outside-editor
branch
from
3ac6370
to
9c348de
Compare
Tug
pushed a commit
that referenced
this pull request
May 12, 2020
…left-border Remove left border of the toolbar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1997
In this PR, I'm limiting the scope of the arrow navigation to the editor area only.