Fix missing label on heading toolbar. #20248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZebulanStanphill
added
[Focus] Accessibility (a11y)
ZebulanStanphill
requested review from
ajitbohra,
jorgefilipecosta,
Soean and
talldan
as code owners
6 tasks
| @@ -48,6 +48,7 @@ class HeadingToolbar extends Component { | |||
| controls={ range( minLevel, maxLevel ).map( ( index ) => | |||
| this.createLevelControl( index, selectedLevel, onChange ) | |||
| ) } | |||
| label={ __( 'Change heading level' ) } | |||
There was a problem hiding this comment.
This matches the labels on other controls, e.g. "Change text alignment".
ZebulanStanphill
added
the
[Type] Bug
talldan
approved these changes
Feb 19, 2020
jorgefilipecosta
added
the
Backport to WP 6.7 Beta/RC
jorgefilipecosta
pushed a commit
that referenced
this pull request
Feb 24, 2020
jorgefilipecosta
pushed a commit
that referenced
this pull request
Feb 24, 2020
jorgefilipecosta
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The heading level toolbar lacked an
aria-label. This PR adds one.