Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest Posts Block: add column slider #2028

Merged
merged 5 commits into from
Jul 27, 2017
Merged

Conversation

mtias
Copy link
Member

@mtias mtias commented Jul 26, 2017

Expands on #1992 providing a control for setting number of columns. Note that, different from galleries, we don't grow individual items and respect the sizing corresponding to the column divisions.

latest-posts-columns

The setting only shows if "grid" layout is selected, as it doesn't make sense for list display.

@mtias mtias added [Feature] Blocks Overall functionality of blocks [Type] Enhancement A suggestion for improvement. labels Jul 26, 2017
@mtias mtias requested review from westonruter and melchoyce July 26, 2017 15:40
@mtias
Copy link
Member Author

mtias commented Jul 26, 2017

Another note: once the main component is updated design wise, both galleries and latest post shall inherit the benefits.

Copy link
Member

@westonruter westonruter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well!

@mtias mtias merged commit 30de3f4 into master Jul 27, 2017
@mtias mtias deleted the add/latest-posts-column-slider branch July 27, 2017 10:01
@StaggerLeee
Copy link

I have "Network suspended" console error when trying to set columns, when post screen is open for longer time. And of course block doesnt change when options are changed.

Can you please just confirm if this plugin is now safe to use with Gutenberg ? Thanks.

https://wordpress.org/plugins/heartbeat-control/

Tug pushed a commit that referenced this pull request Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants