Media: Fix flow for gallery creation and editing #20287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcsf
approved these changes
Feb 18, 2020
There was a problem hiding this comment.
Thanks for the quick fix, @anthonyburchell! This definitely does it for me.
mcsf
added
[Feature] Media
mcsf
changed the title
|
Thanks for testing @mcsf ! I had one change that needed to happen in the doc block to reflect the changes. This should be good now. :) |
jorgefilipecosta
added
the
Backport to WP 6.7 Beta/RC
jorgefilipecosta
pushed a commit
that referenced
this pull request
Feb 24, 2020
* restores Post flow to gallery frames * fixes docs to reflect proper Post frame Props anthonyburchell
jorgefilipecosta
pushed a commit
that referenced
this pull request
Feb 24, 2020
* restores Post flow to gallery frames * fixes docs to reflect proper Post frame Props anthonyburchell
jorgefilipecosta
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See bug report at #17641 (comment). An issue raised that Gallery flows skipped the edit gallery state and also added every image in the image library to the gallery. 😅
This PR restores the Post flow to the gallery frames so that we 1) restore the sidebar that is important to the edit gallery state. 2) Fix the issue where all images are added to the gallery.
This PR also restores the ability to "add to gallery"