Initialize demo content only for new posts #2032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtias
approved these changes
Jul 27, 2017
| @@ -550,7 +551,7 @@ function gutenberg_editor_scripts_and_styles( $hook ) { | |||
| ); | |||
|
|
|||
| // Prepopulate with some test content in demo. | |||
| if ( $is_demo ) { | |||
| if ( $is_new_post && $is_demo ) { | |||
There was a problem hiding this comment.
It's kind of odd that demo is a new post and also a demo. But it may also be a way to initialize any post with existing content, which could be great for ready-made templates.
ceyhun
pushed a commit
that referenced
this pull request
Apr 22, 2020
…le_urls Fix check for file urls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #1929 (comment)
Related: #1984 (cc @westonruter)
This pull request seeks to resolve an issue where saving an edited Demo post and proceeding to refresh the page will not reflect edits made to the Demo.
The cause is two-fold:
?page=gutenberg-demoto?page=gutenbergwhen saving a demo postThe changes herein address the second of these two issues, which fixes the behavior. Ideally we should still seek to remedy the first of these points.
Testing instructions: