Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify cover image markup structure #2038

Merged
merged 2 commits into from
Jul 28, 2017
Merged

Conversation

aduth
Copy link
Member

@aduth aduth commented Jul 26, 2017

This pull request seeks to simplify the markup structure of the cover image block, from a set of two nested section elements to a single section element, flattening classes, and applying the hasBackgroundDim default attribute consistently.

These changes should also resolve the "corrupt" warning shown for the first block in the Demo content screen.

Testing instructions:

Verify that Cover Image block behavior continues to work as expected, particularly dimming and fixed background, and that no warning is shown in the Demo content screen.

@aduth aduth added the [Feature] Blocks Overall functionality of blocks label Jul 26, 2017
@mtias
Copy link
Member

mtias commented Jul 27, 2017

@jasmussen can you give this a look, please?

@jasmussen
Copy link
Contributor

I'm having some trouble with a react dom JS error with the demo content, so I can't check right now sadly. It seems unrelated to this PR, though, as it's happening on all demo content for me.

@youknowriad
Copy link
Contributor

It looks like the frontend styling is broken for this PR

before:
screen shot 2017-07-28 at 13 29 28

after:
screen shot 2017-07-28 at 13 31 00

@aduth
Copy link
Member Author

aduth commented Jul 28, 2017

@youknowriad I'm not able to reproduce the issue you're seeing. I did find that I neglected to deduplicate styles between block.scss and style.scss, updated in 6a960cb. Can you take another look?

Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why but it seems fixed now. Thanks

@aduth aduth force-pushed the update/cover-image-demo-invalid branch from 6a960cb to 40db4e8 Compare July 28, 2017 13:12
@codecov
Copy link

codecov bot commented Jul 28, 2017

Codecov Report

Merging #2038 into master will not change coverage.
The diff coverage is 25%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2038   +/-   ##
=======================================
  Coverage   20.24%   20.24%           
=======================================
  Files         130      130           
  Lines        4184     4184           
  Branches      712      711    -1     
=======================================
  Hits          847      847           
- Misses       2811     2812    +1     
+ Partials      526      525    -1
Impacted Files Coverage Δ
blocks/library/cover-image/index.js 30.43% <25%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb59a8b...40db4e8. Read the comment docs.

@aduth aduth merged commit cec69e8 into master Jul 28, 2017
@aduth aduth deleted the update/cover-image-demo-invalid branch July 28, 2017 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants