-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RNMobile] Cover block - Support adding video background from media library #20463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dratwas
changed the title
[RNMobile] Cover block - Support video background
[WIP][RNMobile] Cover block - Support video background
Feb 26, 2020
Size Change: 0 B Total Size: 866 kB ℹ️ View Unchanged
|
dratwas
requested review from
aduth,
ajitbohra,
chrisvanpatten,
daniloercoli,
ellatrix,
etoledom,
gziolo,
jorgefilipecosta,
mkaz,
mkevins,
nerrad,
ntwb,
pinarol,
SergioEstevao,
Soean,
talldan,
TimothyBJacobs and
youknowriad
as code owners
March 2, 2020 12:19
dratwas
force-pushed
the
rnmobile/cover-block-video
branch
from
March 2, 2020 12:21
875f09c
to
9b97d8a
Compare
dratwas
force-pushed
the
rnmobile/cover-block-video
branch
from
March 2, 2020 12:23
9b97d8a
to
01d845d
Compare
dratwas
changed the title
[WIP][RNMobile] Cover block - Support video background
[RNMobile] Cover block - Support video background
Mar 4, 2020
2 tasks
dratwas
changed the title
[RNMobile] Cover block - Support video background
[RNMobile] Cover block - Support adding video background from media library
Mar 4, 2020
dratwas
requested review from
geriux
and removed request for
SergioEstevao,
talldan,
Soean,
gziolo,
ntwb,
ajitbohra,
chrisvanpatten,
nerrad,
aduth,
TimothyBJacobs,
ellatrix,
pinarol,
mkevins,
etoledom and
jorgefilipecosta
March 9, 2020 09:36
@geriux Could you please review this? :) |
We had this problem on Android in the past so we stopped playing inline video. Let's make sure to test this on a few different Android simulators/devices. |
geriux
approved these changes
Mar 10, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
geriux
added
[Block] Cover
Affects the Cover Block - used to display content laid over a background image
Mobile App - i.e. Android or iOS
Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
labels
Mar 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Block] Cover
Affects the Cover Block - used to display content laid over a background image
Mobile App - i.e. Android or iOS
Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes - wordpress-mobile/gutenberg-mobile#1738
Gutenberg-mobile PR: wordpress-mobile/gutenberg-mobile#1959
In this PR I added the possibility to add video from the media library as a background in the cover block.
How has this been tested?
Test cases:
Test case 1 - render video background on the mobile that is set on the web
Test case 2 - Set video as a background in the mobile app
Test case 3 - render video background on the web that is set on the mobile
Test case 4 - change the image background to the video background
Test case 5 - change the video background to the image background
Test case 6 - change the min-height of the block and the opacity of the overlay
Screenshots
iOS
Set video as a background
Change settings of cover block
Change image to the video and video to the image
Android
Set video as a background
Change settings of cover block
Change image to the video and video to the image
Types of changes
New feature
Checklist: