Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual polish on the prototypes. #205

Merged
merged 3 commits into from
Mar 8, 2017
Merged

Conversation

jasmussen
Copy link
Contributor

This replaces Merriweather with Noto Serif as discussed in a meeting. It also adjusts the active states for buttons.

The font change affects all prototypes.

As a sidenote, setting an alignment doesn't update the active state. Getting an undefined error for updateBlockControlsPosition, which doesn't seem to be a function in the code. Did this regress somehow?

This replaces Merriweather with Noto Serif as discussed in a meeting. It also adjusts the active states for buttons.
@jasmussen jasmussen requested a review from youknowriad March 8, 2017 11:34
jasmussen and others added 2 commits March 8, 2017 12:41
The function updateBlockControlsPosition has been renamed updateDockedControlsPosition
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jasmussen I fixed the updateBlockControlsPosition regression in 852daf1. Sorry about that :)

The updated CSS/Fonts are looking great (I do prefer the old lighter toolbars, but I understand the accessibility issues)

@jasmussen
Copy link
Contributor Author

Thank you!

The is-active isn't set on the button that toggles the alignments, though:

screen shot 2017-03-08 at 12 51 14

Perhaps we never got that working initially?

@ellatrix
Copy link
Member

ellatrix commented Mar 8, 2017

Looking good! Should the button icons be lighter by default? It makes it slightly less readable.

@jasmussen
Copy link
Contributor Author

Looking good! Should the button icons be lighter by default? It makes it slightly less readable.

This is something we can tune to perfection as we keep iterating. Let's try this for now. Going to see if I can do some sharing of styles across the prototypes, so we can normalize. Sorry I haven't been there to do this before.

@ellatrix
Copy link
Member

ellatrix commented Mar 8, 2017

If we opt for a border, maybe just on the bottom makes is slightly less busy?

screenshot 2017-02-23 19 59 19

@ellatrix
Copy link
Member

ellatrix commented Mar 8, 2017

Going to see if I can do some sharing of styles across the prototypes, so we can normalize.

I can add the style for the single MCE one if you like.

@jasmussen
Copy link
Contributor Author

I can add the style for the single MCE one if you like.

I'd like to try and explore the shared CSS file a bit further, see if we can do some magic here. I could also swear I saw a SASS variable somewhere, which would be a great way to normalize colors.

@youknowriad
Copy link
Contributor

Perhaps we never got that working initially?

@jasmussen Yes, we never updated the active button on the alignment toolbar

@jasmussen jasmussen merged commit 5f809c9 into master Mar 8, 2017
@jasmussen jasmussen deleted the update/prototype-design branch March 8, 2017 12:00
@jasmussen
Copy link
Contributor Author

If we opt for a border, maybe just on the bottom makes is slightly less busy?

Let's try the full border for now, see how it feels when we use it everywhere. This is yet another aspect I suspect will keep getting tuned.

nylen pushed a commit that referenced this pull request Mar 16, 2017
hypest pushed a commit that referenced this pull request Nov 2, 2018
…lock

Add the react-native-hr library to GB mobile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants