-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visual polish on the prototypes. #205
Conversation
This replaces Merriweather with Noto Serif as discussed in a meeting. It also adjusts the active states for buttons.
The function updateBlockControlsPosition has been renamed updateDockedControlsPosition
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jasmussen I fixed the updateBlockControlsPosition
regression in 852daf1. Sorry about that :)
The updated CSS/Fonts are looking great (I do prefer the old lighter toolbars, but I understand the accessibility issues)
Looking good! Should the button icons be lighter by default? It makes it slightly less readable. |
This is something we can tune to perfection as we keep iterating. Let's try this for now. Going to see if I can do some sharing of styles across the prototypes, so we can normalize. Sorry I haven't been there to do this before. |
I can add the style for the single MCE one if you like. |
I'd like to try and explore the shared CSS file a bit further, see if we can do some magic here. I could also swear I saw a SASS variable somewhere, which would be a great way to normalize colors. |
@jasmussen Yes, we never updated the active button on the alignment toolbar |
Let's try the full border for now, see how it feels when we use it everywhere. This is yet another aspect I suspect will keep getting tuned. |
Visual polish on the prototypes.
…lock Add the react-native-hr library to GB mobile
This replaces Merriweather with Noto Serif as discussed in a meeting. It also adjusts the active states for buttons.
The font change affects all prototypes.
As a sidenote, setting an alignment doesn't update the active state. Getting an undefined error for
updateBlockControlsPosition
, which doesn't seem to be a function in the code. Did this regress somehow?