Remove potentially useless style override for floats #20501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
requested review from
ajitbohra,
ellatrix,
jorgefilipecosta,
Soean and
talldan
as code owners
youknowriad
force-pushed
the
remove/useless-style-override
branch
from
80b539a to
2ff52ef
Compare
|
Size Change: -86 B (0%) Total Size: 866 kB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Feb 28, 2020
There was a problem hiding this comment.
The rule was introduced to address feedback we received at the time regarding how the block boundaries behaved. That is, the gray border that was painted outside each block, which was conflicting with floats.
Specifically this broke down if the very first block in the blocklist was floated, it would interfere with the title, which was not a block.
The substantial refactors made both to the block UI, to the margins and paddings in the editing canvas, and to the title itself, makes this CSS redundant. It's a pleasure to bid it farewell.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #17196
This style affects any floated block if it's the first block inside a container (or canvas).
I'm not really certain why this was added in the first place (introduced in #11357 ) but it seems useless for me and removing it solves #17196
Any ideas @jasmussen do we still need this style?