Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improves RTL style conversion #20503

Merged
merged 8 commits into from
Mar 12, 2020
Merged

Improves RTL style conversion #20503

merged 8 commits into from
Mar 12, 2020

Commits on Feb 28, 2020

  1. Improves rtl style conversion + adds tests 

    This update improves the rtl style utility to better handle varying combinations of `left` and `Left` based properties. A handful of tests have been added to ensure style property conversions are outputted as expected.
    @aduth
    Jon Q authored and aduth committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    b43a609 View commit details
    Browse the repository at this point in the history

  2. Adds support for left->right and right->left. 

    Also adds tests
    @aduth
    Jon Q authored and aduth committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    921b2a5 View commit details
    Browse the repository at this point in the history

  3. Components: Add RTL conversion edge case test

    @aduth
    aduth committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    7906362 View commit details
    Browse the repository at this point in the history

  4. Rename rtl.test.js to rtl.js

    @aduth
    Jon Q authored and aduth committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    8124ec2 View commit details
    Browse the repository at this point in the history

  5. Fixes upright CSS property use case. Adds tests for scroll padding/ma… 

    …rgin
    @aduth
    Jon Q authored and aduth committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    ed7a6d9 View commit details
    Browse the repository at this point in the history

  6. Converts Regex to const. Refactors left/right key conversion utility.

    @aduth
    Jon Q authored and aduth committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    6aeed6f View commit details
    Browse the repository at this point in the history

  7. Adds and improves comments for rtl functions.

    @aduth
    Jon Q authored and aduth committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    7588099 View commit details
    Browse the repository at this point in the history

  8. Simplify with lodash.mapKeys and rename function to match standards

    @aduth
    Jon Q authored and aduth committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    1b95d4f View commit details
    Browse the repository at this point in the history