Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go back to default codecov settings #2055

Merged
merged 2 commits into from
Jul 27, 2017
Merged

Go back to default codecov settings #2055

merged 2 commits into from
Jul 27, 2017

Conversation

nylen
Copy link
Member

@nylen nylen commented Jul 27, 2017

Follow-up to #2054.

curl --data-binary @codecov.yml https://codecov.io/validate

This command documented here revealed some errors. The desired result for now is that Codecov.io shows up as a commit status like Travis but does not leave comments on PRs.

`curl --data-binary @codecov.yml https://codecov.io/validate`
@nylen
Copy link
Member Author

nylen commented Jul 27, 2017

Let's leave as-is for now:

@nylen nylen closed this Jul 27, 2017
@nylen nylen deleted the fix/codecov-yml branch July 27, 2017 14:35
@nylen nylen restored the fix/codecov-yml branch July 27, 2017 14:35
@nylen nylen reopened this Jul 27, 2017
@nylen
Copy link
Member Author

nylen commented Jul 27, 2017

... and by "leave as-is", what I really meant was "go back to the default settings".

@codecov-io
Copy link

Codecov Report

Merging #2055 into master will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2055      +/-   ##
=========================================
+ Coverage   18.82%   18.9%   +0.08%     
=========================================
  Files         129     130       +1     
  Lines        4197    4215      +18     
  Branches      716     719       +3     
=========================================
+ Hits          790     797       +7     
- Misses       2868    2878      +10     
- Partials      539     540       +1
Impacted Files Coverage Δ
blocks/library/more/index.js 30% <0%> (ø)
blocks/api/serializer.js 100% <0%> (+3.03%) ⬆️
blocks/library/quote/index.js 18.6% <0%> (+4.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4a30ac...19cad41. Read the comment docs.

@nylen
Copy link
Member Author

nylen commented Jul 27, 2017

☝️ there are some configuration settings for these comments documented at https://docs.codecov.io/docs/pull-request-comments.

@nylen nylen changed the title Fix codecov.yml Go back to default codecov settings Jul 27, 2017
@nylen nylen merged commit db05898 into master Jul 27, 2017
@nylen nylen deleted the fix/codecov-yml branch July 27, 2017 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants