-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(env): escape pipes in table cells #20660
Conversation
Will the escape be a problem, when we render it on https://developer.wordpress.org/block-editor/packages/packages-env/#wp-env-json ? |
@Soean Can you give me a hint, how I can test this? I didn't found a way to generate the HTML docs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely looks better in GitHub. Thanks @simono! If it breaks wordpress.org then we should fix the parser that builds those docs pages.
@noisysocks Now the backslash is rendered in the handbook: https://developer.wordpress.org/block-editor/packages/packages-env/#wp-env-json |
@noisysocks @Soean Thanks for the merge. Let me know if I can help to fix the backslashes in the handbook. |
I created a ticket for the parsing issue in Meta Trac: https://meta.trac.wordpress.org/ticket/5123 This is the plugin that parses the markdown, if you'd like to try your hand at writing a patch to fix the issue: https://meta.trac.wordpress.org/browser/sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-markdown |
See https://github.github.com/gfm/#example-200
Description
Fixed pipes inside tables cells.
How has this been tested?
Content is now displayed correctly on the GitHub page.
Types of changes
Doc improvements.
Checklist: