Lighter block DOM: Navigation #20729
Conversation
ellatrix
requested review from
ajitbohra,
jorgefilipecosta,
Soean,
talldan and
youknowriad
as code owners
|
Size Change: -270 B (0%) Total Size: 864 kB
ℹ️ View Unchanged
|
ellatrix
force-pushed
the
try/light-navigation
branch
from
9a696c2
to
40ca7ec
Compare
ellatrix
force-pushed
the
try/light-navigation
branch
from
c0124da
to
a7eb485
Compare
|
This is looking pretty good and I don't see any regressions. It may be that there's a slight difference in the editor, but nothing that I'm seeing right now. If there's a regression, I'll create a follow up PR. As noted above, I believe this is a big step in the direction of being able to share more styles between the front-end and editor. |
|
This caused a small regression. Before:
After:
It appears this rule is at fault:
The width of the |
|
@jasmussen Strange, for me the inserter icon appeared horizontally. I'll check again. |
|
@jasmussen I'm seeing this:
|
|
Oohh it may be a TwentyNineteen issue. Let me verify. |
|
Oooh, sorry, I didn't pull the new commits yet. |
|
Confirmed 😱 Thanks for bearing with my bad report here! Though I do suspect that as the DOM gets closer to the frontend (yaaay) we'll see more and more of these things pop up due to themes doing their best to style the old markup. |
|
Pulled the commits, and it's still fine:
|
|
Yep, it's TwentyNineteen. I'll create a trac ticket when I have a moment. |
|
@jasmussen Tbh, I think we should attempt to also remove the appender from the editor DOM, and float it behind the last items or something, similar to the sibling inserter (in between inserter). The appender shouldn't be part of the content and take up space. We have a similar problem in the column block where the appender continuously changes the height of the column without any actual content being changed. |
|
I've no strong opionion there. But would you suggest not creating a trac ticket to fix this in TwentyNineteen? |
|
@jasmussen Oh, I'm not opposed to patching anything up in the meantime. :) |
|
Created https://core.trac.wordpress.org/ticket/49613 to track it :) |
Description
Makes the navigation block (and inner blocks) light blocks. The goal is to have the same structure as the front-end.
Especially worth noting is the fact that we can now use the
ulandlitags. This is something that wasn't possible before because the list items couldn't be direct children oful.How has this been tested?
Screenshots
Types of changes
Checklist: