Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid block warning text overflow in IE11 #2074

Merged
merged 1 commit into from
Jul 28, 2017

Conversation

aduth
Copy link
Member

@aduth aduth commented Jul 28, 2017

Fixes #2073
See: https://stackoverflow.com/a/35113633

This pull request seeks to resolve a styling issue which occurs in the invalid block warning, affecting IE11 only.

Before After
Before After

Testing instructions:

Repeat steps to reproduce from #2073, verifying that an invalid block warning displays correctly in IE11.

@codecov
Copy link

codecov bot commented Jul 28, 2017

Codecov Report

Merging #2074 into master will decrease coverage by 0.57%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2074      +/-   ##
==========================================
- Coverage   20.25%   19.68%   -0.58%     
==========================================
  Files         131      131              
  Lines        4207     4441     +234     
  Branches      716      800      +84     
==========================================
+ Hits          852      874      +22     
- Misses       2827     2959     +132     
- Partials      528      608      +80
Impacted Files Coverage Δ
blocks/editable/index.js 0.29% <0%> (-0.18%) ⬇️
editor/modes/visual-editor/index.js 0% <0%> (ø) ⬆️
editor/index.js 0% <0%> (ø) ⬆️
editor/modes/visual-editor/block.js 0% <0%> (ø) ⬆️
editor/utils/undoable-reducer.js 100% <0%> (+3.22%) ⬆️
editor/actions.js 41.66% <0%> (+4.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9a619d...774594c. Read the comment docs.

@aduth aduth merged commit e36ff3e into master Jul 28, 2017
@aduth aduth deleted the fix/2073-ie11-invalid-warning branch July 28, 2017 14:58
@nylen
Copy link
Member

nylen commented Jul 30, 2017

I would have expected codecov to ignore this PR entirely. As of #2092 it will not leave comments on PRs that do not change coverage, and at https://github.com/codecov/support/issues/427 I've asked for some support regarding why this PR was reported as a coverage change.

ceyhun pushed a commit that referenced this pull request Apr 22, 2020
* Update Gutenberg reference

* Update App Bundle

* Update ref

Co-authored-by: Pinar Olguc <pinarolguc@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Text overflow on invalid block warning in IE11
2 participants