Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paragraph: Add LineHeightControl + Attribute #20775

Merged
merged 30 commits into from
Mar 27, 2020
Merged

Paragraph: Add LineHeightControl + Attribute #20775

merged 30 commits into from
Mar 27, 2020

Commits on Mar 27, 2020

  1. Update emotion library to latest. Adds to block-library package.

    @youknowriad
    Jon Q authored and youknowriad committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    b9c4827 View commit details
    Browse the repository at this point in the history

  2. Add LineHeightControl component to block-editor

    @youknowriad
    Jon Q authored and youknowriad committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    58d57f7 View commit details
    Browse the repository at this point in the history

  3. Export LineHeightControl as experimental from block-editor

    @youknowriad
    Jon Q authored and youknowriad committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    d7fba5e View commit details
    Browse the repository at this point in the history

  4. Hook up LineHeightControl with core Paragraph block

    @youknowriad
    Jon Q authored and youknowriad committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    9319076 View commit details
    Browse the repository at this point in the history

  5. Improve undefined/reset interactions for line-height attribute

    @youknowriad
    Jon Q authored and youknowriad committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    38c4404 View commit details
    Browse the repository at this point in the history

  6. Refactor store hook usage with LineHeightControl

    @youknowriad
    Jon Q authored and youknowriad committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    7867960 View commit details
    Browse the repository at this point in the history

  7. Refactor with withLineHeight HOC for Edit and Save components

    @youknowriad
    Jon Q authored and youknowriad committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    bb61179 View commit details
    Browse the repository at this point in the history

  8. Improve reset logic. Simplifies stlye value output.

    @youknowriad
    Jon Q authored and youknowriad committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    0facc59 View commit details
    Browse the repository at this point in the history

  9. Refactor function names and comments

    @youknowriad
    Jon Q authored and youknowriad committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    601a1f2 View commit details
    Browse the repository at this point in the history

  10. Fix import/export of new experimental attribute hooks

    @youknowriad
    Jon Q authored and youknowriad committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    d455c17 View commit details
    Browse the repository at this point in the history

  11. Export LineHeightControls and withLineHeight for native

    @youknowriad
    Jon Q authored and youknowriad committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    ce678af View commit details
    Browse the repository at this point in the history

  12. Adjust mechanism to get block attributes in useBlockAttributes hook

    @youknowriad
    Jon Q authored and youknowriad committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    499d59e View commit details
    Browse the repository at this point in the history

  13. Add theme support for disable-custom-line-height

    @youknowriad
    Jon Q authored and youknowriad committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    c329f21 View commit details
    Browse the repository at this point in the history

  14. Clarify logic + add comments for lineHeight attribute -> value evalua… 

    …tion
    @youknowriad
    Jon Q authored and youknowriad committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    2d6beb4 View commit details
    Browse the repository at this point in the history

  15. Simplify CSS output for lineHeight in paragraph block

    @youknowriad
    Jon Q authored and youknowriad committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    2e99301 View commit details
    Browse the repository at this point in the history

  16. Add experimental prefix for disableCustomLineHeight setting

    @youknowriad
    Jon Q authored and youknowriad committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    864e8ea View commit details
    Browse the repository at this point in the history

  17. Add comment for :root based CSS rule

    @youknowriad
    Jon Q authored and youknowriad committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    cc18a2b View commit details
    Browse the repository at this point in the history

  18. Removes @emotion from block-library. Refactor to use scss

    @youknowriad
    Jon Q authored and youknowriad committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    0838ee0 View commit details
    Browse the repository at this point in the history

  19. Remove withLineHeight HOC abstraction. 

    Reverted to use inline styles instead of CSS variable for line-height style rendering
    @youknowriad
    Jon Q authored and youknowriad committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    002e753 View commit details
    Browse the repository at this point in the history

  20. Revert className implementation 

    Also revert @emotion library versions to master
    @youknowriad
    Jon Q authored and youknowriad committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    3bd0457 View commit details
    Browse the repository at this point in the history

  21. Revert @emotion/native from 10.0.23 -> 10.0.22 (to match master)

    @youknowriad
    Jon Q authored and youknowriad committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    bda4f0e View commit details
    Browse the repository at this point in the history

  22. Updates package-lock.json

    @youknowriad
    Jon Q authored and youknowriad committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    5900583 View commit details
    Browse the repository at this point in the history

  23. Fix e2e test to target correct text input

    @youknowriad
    Jon Q authored and youknowriad committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    35794cc View commit details
    Browse the repository at this point in the history

  24. Reverting package-lock.json

    @youknowriad
    Jon Q authored and youknowriad committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    bf7ef83 View commit details
    Browse the repository at this point in the history

  25. Provide clientId in dependency array in useSetAttributes hook

    @youknowriad
    Jon Q authored and youknowriad committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    96d4158 View commit details
    Browse the repository at this point in the history

  26. Use CSS variables and a support flag for the line height customization

    @youknowriad
    youknowriad committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    5f43e25 View commit details
    Browse the repository at this point in the history

  27. Improves handling of "zero" key press

    @youknowriad
    Jon Q authored and youknowriad committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    c449aad View commit details
    Browse the repository at this point in the history

  28. Update packages/block-editor/src/components/line-height-control/utils.js 

    Co-Authored-By: Zebulan Stanphill <zebulanstanphill@protonmail.com>
    @ZebulanStanphill @youknowriad
    2 people authored and youknowriad committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    5923ffc View commit details
    Browse the repository at this point in the history

  29. Remove unused import

    @youknowriad
    Jon Q authored and youknowriad committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    777f079 View commit details
    Browse the repository at this point in the history

  30. Remove useless hooks file

    @youknowriad
    youknowriad committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    a129ab8 View commit details
    Browse the repository at this point in the history