Reduce gap between block library and preview #20777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +414 B (0%) Total Size: 864 kB
ℹ️ View Unchanged
|
|
@jasmussen I'd love to know if there's a better way to add the border radius and box-shadow styles from I attempeted to add |
jasmussen
reviewed
Mar 11, 2020
|
|
||
| @include break-medium { | ||
| position: absolute; | ||
| top: 0; | ||
| left: calc(100% + 20px); | ||
| top: -1px; |
There was a problem hiding this comment.
You could do -$border-width here instead of -1px, because the reason it's offset by one is because of the border, as best I can tell, that helps "document" the code.
jasmussen
reviewed
Mar 11, 2020
| top: 0; | ||
| left: calc(100% + 20px); | ||
| top: -1px; | ||
| left: calc(100% + 12px); |
There was a problem hiding this comment.
You can use $grid-unit-15here instead of 12px, as it's part of the grid spacing!
Because it's part of a calc rule, you may have to do this: left: calc(100% + #{$grid-unit-15});
jasmussen
approved these changes
Mar 11, 2020
|
Thank you so much @jasmussen! |
enriquesanchez
deleted the
try/bring-block-preview-popover-closer-to-library
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #20747. These are minor CSS changes that reduce the gap between the block library and the preview popover.
It also adds border radius and box shadow to the preview popover.
Screenshots
Before:
After:
Types of changes
CSS changes.