Fix auto-hiding appender regression. #20780
Conversation
In #20753 I caused a regression that collapsed the big square appender that exists in an empty columns block, or an empty group block. The only thing that should collapse, until selected, is the black appender button inside blocks like Social Links, Buttons, or Navigation Menu. This PR fixes that regression by scoping the animation to said button.
jasmussen
added
[Type] Bug
|
Size Change: +4 B (0%) Total Size: 864 kB
ℹ️ View Unchanged
|
|
Hey @ItsJonQ my friend, I would appreciate your thoughts on this one. I think this PR is fairly solid as it fixes the regression I introduced, so we should consider merging it. However you can see the reason why the regression was introduced in the first place was because of handling in CSS something that should perhaps be handled in a better way. If you have the time and energy, do you have some insights to share as to how this might be handled better? |
|
@jasmussen I'll take a looksy! 🤗 |
|
Thanks. Should we merge this one in the mean time? It's either that, or revert my previous PR. Open to either, but I'm feeling pretty solid about this one. The key to look for when testing: — the black plus should disappear on social links, navigation menu and buttons, and appear when selected. But the white appeander that sits in an empty group block, or an empty colums block, should always be visible. |
|
@jasmussen Merge it up 💪 . I just took a quick look. In general, I think the closer we tie interaction/style logic JS (React components) the less brittle it would be. The class update you made is a great example. It feels like a very loose connection between function (component) and style (presentation). The more compounded classes there are, the looser the connection feels (at least to me) 😊 |
|
Thanks Q! Your assessment of the behavior is also an eloquent expression of what I sensed writing the CSS. It works, but it could be clean and more solid. |
In #20753 I caused a regression that collapsed the big square appender that exists in an empty columns block, or an empty group block.
The only thing that should collapse, until selected, is the black appender button inside blocks like Social Links, Buttons, or Navigation Menu.
This PR fixes that regression by scoping the animation to said button.