Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eriktdesign add/tags in latest posts block #20785

Closed
wants to merge 2 commits into from

Conversation

draganescu
Copy link
Contributor

@draganescu draganescu commented Mar 11, 2020

WORK IN PROGRESS!

Description

Props @eriktdesign, this is a refresh of #19755
Moves #13027 forward by adding filtering by tags.

How has this been tested?

Tested locally.

  1. Make sure you have some posts with tags
  2. Make a new post/page
  3. Add a LatestPosts block
  4. Use the tag filter in the inspector

Screenshots

Screenshot 2020-03-11 at 12 19 31

Types of changes

Non breaking addition to LatestPosts and QuerySelector

Checklist:

  • Make the tag list a multiple selection

@github-actions
Copy link

github-actions bot commented Mar 11, 2020

Size Change: +687 B (0%)

Total Size: 857 kB

Filename Size Change
build/annotations/index.js 3.43 kB +1 B
build/block-directory/index.js 6.02 kB -1 B
build/block-editor/index.js 100 kB +1 B
build/block-library/index.js 111 kB +599 B (0%)
build/blocks/index.js 57.5 kB +1 B
build/components/index.js 191 kB +86 B (0%)
build/core-data/index.js 10.6 kB -3 B (0%)
build/data-controls/index.js 1.04 kB +1 B
build/list-reusable-blocks/index.js 2.99 kB +1 B
build/media-utils/index.js 4.84 kB +1 B
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 998 B 0 B
build/api-fetch/index.js 3.39 kB 0 B
build/autop/index.js 2.58 kB 0 B
build/blob/index.js 620 B 0 B
build/block-directory/style-rtl.css 760 B 0 B
build/block-directory/style.css 760 B 0 B
build/block-editor/style-rtl.css 10.9 kB 0 B
build/block-editor/style.css 10.9 kB 0 B
build/block-library/editor-rtl.css 7.24 kB 0 B
build/block-library/editor.css 7.24 kB 0 B
build/block-library/style-rtl.css 7.41 kB 0 B
build/block-library/style.css 7.42 kB 0 B
build/block-library/theme-rtl.css 669 B 0 B
build/block-library/theme.css 671 B 0 B
build/block-serialization-default-parser/index.js 1.65 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/components/style-rtl.css 15.8 kB 0 B
build/components/style.css 15.7 kB 0 B
build/compose/index.js 6.21 kB 0 B
build/data/index.js 8.2 kB 0 B
build/date/index.js 5.37 kB 0 B
build/deprecated/index.js 771 B 0 B
build/dom-ready/index.js 568 B 0 B
build/dom/index.js 3.06 kB 0 B
build/edit-post/index.js 91.2 kB 0 B
build/edit-post/style-rtl.css 8.47 kB 0 B
build/edit-post/style.css 8.46 kB 0 B
build/edit-site/index.js 5.56 kB 0 B
build/edit-site/style-rtl.css 2.62 kB 0 B
build/edit-site/style.css 2.62 kB 0 B
build/edit-widgets/index.js 4.43 kB 0 B
build/edit-widgets/style-rtl.css 2.58 kB 0 B
build/edit-widgets/style.css 2.58 kB 0 B
build/editor/editor-styles-rtl.css 381 B 0 B
build/editor/editor-styles.css 382 B 0 B
build/editor/index.js 43.8 kB 0 B
build/editor/style-rtl.css 3.97 kB 0 B
build/editor/style.css 3.96 kB 0 B
build/element/index.js 4.44 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/index.js 6.95 kB 0 B
build/format-library/style-rtl.css 502 B 0 B
build/format-library/style.css 502 B 0 B
build/hooks/index.js 1.93 kB 0 B
build/html-entities/index.js 621 B 0 B
build/i18n/index.js 3.49 kB 0 B
build/is-shallow-equal/index.js 711 B 0 B
build/keyboard-shortcuts/index.js 2.3 kB 0 B
build/keycodes/index.js 1.69 kB 0 B
build/list-reusable-blocks/style-rtl.css 226 B 0 B
build/list-reusable-blocks/style.css 226 B 0 B
build/notices/index.js 1.58 kB 0 B
build/nux/index.js 3.01 kB 0 B
build/nux/style-rtl.css 616 B 0 B
build/nux/style.css 613 B 0 B
build/plugins/index.js 2.54 kB 0 B
build/primitives/index.js 1.5 kB 0 B
build/priority-queue/index.js 780 B 0 B
build/redux-routine/index.js 2.83 kB 0 B
build/rich-text/index.js 14.4 kB 0 B
build/server-side-render/index.js 2.55 kB 0 B
build/shortcode/index.js 1.7 kB 0 B
build/token-list/index.js 1.27 kB 0 B
build/url/index.js 4.01 kB 0 B
build/viewport/index.js 1.61 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.18 kB 0 B

compressed-size-action

@draganescu draganescu force-pushed the eriktdesign-add/tags-in-latest-posts-block branch from 7488070 to f995e0c Compare March 16, 2020 07:22
@draganescu
Copy link
Contributor Author

draganescu commented Mar 16, 2020

I updated this but currently have some glitching behavior when tags are added:

tags-filter

@draganescu
Copy link
Contributor Author

There are also a design issue that should be solved for this PR:

  • The token field for adding tags supports adding tags when the tags don't exist. However in this context I don't expect that a non-existent tag should work. So when I type some text for which there are no suggestions:

a) nothing happens and ENTER key makes my text disappear (current behavior)
b) some warning message is shown that there is no such tag

I will implement b) but a sort of mock-up as to where should I display that message would be good.

@draganescu draganescu force-pushed the eriktdesign-add/tags-in-latest-posts-block branch from 7377e3a to 0dfe1b0 Compare March 20, 2020 11:55
@pbrocks
Copy link

pbrocks commented Apr 3, 2020

Using Gutenberg.run, I added some posts via XML, then added the Latest Posts block to another post. The block showed the latest 5 posts by default and when a tag is added to the input element in the inspector controls, the block refreshes with newly polled data according to the new criteria.

latest-posts-polls-4-tags-gutenberg-run

@draganescu draganescu closed this Jul 24, 2020
@draganescu
Copy link
Contributor Author

Closed b/c of lack of traction and the upcoming Query block's replacing the LP block.

@aristath aristath deleted the eriktdesign-add/tags-in-latest-posts-block branch November 10, 2020 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Design Feedback Needs general design feedback.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants