Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add radio option to ButtonGroup #20805

Merged
merged 38 commits into from
Apr 8, 2020
Merged

Add radio option to ButtonGroup #20805

merged 38 commits into from
Apr 8, 2020

Commits on Mar 11, 2020

  1. Add radio mode to ButtonGroup with aria attributes

    @ajlende
    ajlende committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    5ccd36f View commit details
    Browse the repository at this point in the history

  2. Destructure child props

    @ajlende
    ajlende committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    c942d56 View commit details
    Browse the repository at this point in the history

  3. Add tab index for radio buttons

    @ajlende
    ajlende committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    9c85fc3 View commit details
    Browse the repository at this point in the history

  4. Add keyboard handlers

    @ajlende
    ajlende committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    726ac0e View commit details
    Browse the repository at this point in the history

  5. Remove TODO comment 

    Current behavior is consistent with RadioControl
    @ajlende
    ajlende committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    42e671c View commit details
    Browse the repository at this point in the history

  6. Add storybook example

    @ajlende
    ajlende committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    4a061ff View commit details
    Browse the repository at this point in the history

  7. Add documentation example

    @ajlende
    ajlende committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    4373a44 View commit details
    Browse the repository at this point in the history

  8. Add StoryShot snapshot

    @ajlende
    ajlende committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    adf8bab View commit details
    Browse the repository at this point in the history

  9. Mention ButtonGroup in RadioControl

    @ajlende
    ajlende committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    cb97066 View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2020

  1. Merge branch 'master' of github.com:WordPress/gutenberg into try/radi… 

    …o-button-group
    @ajlende
    ajlende committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    0ca5022 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2020

  1. Merge branch 'master' of github.com:WordPress/gutenberg into try/radi… 

    …o-button-group
    @ajlende
    ajlende committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    a39023b View commit details
    Browse the repository at this point in the history

  2. Convert to using context instead of cloneElement

    @ajlende
    ajlende committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    f798e69 View commit details
    Browse the repository at this point in the history

  3. Merge refs so forwardRef is still usable with radio group

    @ajlende
    ajlende committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    1af2d22 View commit details
    Browse the repository at this point in the history

  4. Refactor to move button props to button component

    @ajlende
    ajlende committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    daca280 View commit details
    Browse the repository at this point in the history

  5. Refactor for readability

    @ajlende
    ajlende committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    c946eab View commit details
    Browse the repository at this point in the history

  6. Add comment about default value

    @ajlende
    ajlende committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    3083dc6 View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2020

  1. Consolidate ref and className

    @ajlende
    ajlende committed Mar 26, 2020
    Configuration menu
    Copy the full SHA
    4242001 View commit details
    Browse the repository at this point in the history

  2. Fix useMemo return value

    @ajlende
    ajlende committed Mar 26, 2020
    Configuration menu
    Copy the full SHA
    86d1088 View commit details
    Browse the repository at this point in the history

  3. Update snapshots 

    Reordered props and removed value prop
    @ajlende
    ajlende committed Mar 26, 2020
    Configuration menu
    Copy the full SHA
    282ed66 View commit details
    Browse the repository at this point in the history

  4. Partially revert snapshots

    @ajlende
    ajlende committed Mar 26, 2020
    Configuration menu
    Copy the full SHA
    c0d3d51 View commit details
    Browse the repository at this point in the history

  5. Update prop order to match snapshots

    @ajlende
    ajlende committed Mar 26, 2020
    Configuration menu
    Copy the full SHA
    bd0f097 View commit details
    Browse the repository at this point in the history

  6. Update comments for clarity

    @ajlende
    ajlende committed Mar 26, 2020
    Configuration menu
    Copy the full SHA
    287c9f0 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' of github.com:WordPress/gutenberg into try/radi… 

    …o-button-group
    @ajlende
    ajlende committed Mar 26, 2020
    Configuration menu
    Copy the full SHA
    a0b7581 View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2020

  1. Move changes to radio-group and radio

    @ajlende
    ajlende committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    213673e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into try/radio-button-group

    @ajlende
    ajlende committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    4b2851c View commit details
    Browse the repository at this point in the history

  3. Remove radio button group storybook snapshot

    @ajlende
    ajlende committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    d724209 View commit details
    Browse the repository at this point in the history

  4. Update ButtonGroup extra props to override role

    @ajlende
    ajlende committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    10d7e26 View commit details
    Browse the repository at this point in the history

  5. Implement forwardRef for ButtonGroup

    @ajlende
    ajlende committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    c01c3bf View commit details
    Browse the repository at this point in the history

  6. Update snapshot with forwardRef(ButtonGroup)

    @ajlende
    ajlende committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    3129af7 View commit details
    Browse the repository at this point in the history

  7. Update RadioControl to mention RadioGroup

    @ajlende
    ajlende committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    37dc2b1 View commit details
    Browse the repository at this point in the history

  8. Replace Radio/RadioGroup with Reakit version

    @ajlende
    ajlende committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    c07e117 View commit details
    Browse the repository at this point in the history

  9. Add storybook stories for Radio/RadioGroup

    @ajlende
    ajlende committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    3def111 View commit details
    Browse the repository at this point in the history

  10. Update Radio/RadioGroup READMEs

    @ajlende
    ajlende committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    4f66910 View commit details
    Browse the repository at this point in the history

  11. Update docs manifest

    @ajlende
    ajlende committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    c611871 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2020

  1. Add __experimental prefix for Radio/RadioGroup

    @ajlende
    ajlende committed Apr 4, 2020
    Configuration menu
    Copy the full SHA
    7a417ac View commit details
    Browse the repository at this point in the history

  2. Pass through disabled state to children

    @ajlende
    ajlende committed Apr 4, 2020
    Configuration menu
    Copy the full SHA
    538538f View commit details
    Browse the repository at this point in the history

  3. Remove Radio ids from stories

    @ajlende
    ajlende committed Apr 4, 2020
    Configuration menu
    Copy the full SHA
    da54def View commit details
    Browse the repository at this point in the history

  4. Update snapshots

    @ajlende
    ajlende committed Apr 4, 2020
    Configuration menu
    Copy the full SHA
    f2dad34 View commit details
    Browse the repository at this point in the history