Update the inserter's block preview to use the AutoHeightPreview #20817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Bug
|
Size Change: -37 B (0%) Total Size: 864 kB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Mar 12, 2020
| @@ -229,6 +220,7 @@ $block-inserter-search-height: 38px; | |||
| border: $border-width solid $light-gray-500; | |||
| border-radius: $radius-round-rectangle; | |||
| align-items: center; | |||
| min-height: 150px; | |||
There was a problem hiding this comment.
Can we use a variable here? Or at least something grid friendly like $grid-unit-60 * 3? I know no-one will really notice this, but I just don't like arbitrarily picked numbers :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #20713
Fixes the trimmed previews by using au automatic computed height for block previews.