Fix Full width movers #20829
Closed
Fix Full width movers #20829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Bug
youknowriad
commented
Mar 12, 2020
| .block-editor-block-contextual-toolbar[data-align="full"], | ||
| .block-editor-block-list__breadcrumb[data-align="full"] { | ||
| margin-left: 0; | ||
| } |
There was a problem hiding this comment.
@jasmussen do you know the purpose of these styles? why we had them?
|
Size Change: -15 B (0%) Total Size: 864 kB
ℹ️ View Unchanged
|
|
Actually, it seems this is needed otherwise the block toolbar goes out of screen. I was testing the wide alignments :P and didn't notice. |
Same for me at Gutenberg 7.7.1 The bug seems not to be fixed : margin-left is required for full-width blocks, otherwise the block mover goes out of the screen. But if its set, dragging doesnt work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #20451
On full width blocks, the block movers was not accessible. You can see it but not click it.
Testing instructions
Repeat instructions from #20451 and notice that you can move the full width blocks.