Moves category multi select from LatestPosts to QueryControls #20832
Conversation
…date/categories-select-multiple
Ringish
requested review from
ajitbohra,
chrisvanpatten,
jorgefilipecosta,
Soean,
talldan and
youknowriad
as code owners
There was a problem hiding this comment.
Awesome and super fast @Ringish :) Left two minor comments, thanks!
| @@ -37,6 +37,14 @@ export default function QueryControls( { | |||
| onOrderChange, | |||
| onOrderByChange, | |||
| } ) { | |||
| const suggestions = categoriesList.reduce( | |||
There was a problem hiding this comment.
Let's call this categorySuggestions because if we add other flat taxonomies they'll also have suggestions.
| value: item.name || item.value, | ||
| } ) ) | ||
| } | ||
| suggestions={ Object.keys( suggestions ) } |
There was a problem hiding this comment.
the FormTokenField has a maxSuggestions prop what we should use for cases when categories are not for content and so are too many in number.
There was a problem hiding this comment.
What value should be max?
There was a problem hiding this comment.
Let's use a constant and the same value the FlatTermSelector component is using:
const MAX_TERMS_SUGGESTIONS = 20;
|
I think we should merge this before I move on with #20831. |
There was a problem hiding this comment.
Great @Ringish I will merge this to clean up the component and lessen the future conflicts.
Description
Solves #20826.
How has this been tested?
Screenshots
Types of changes
File structure fix!
Checklist: