-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patterns: Make adding patterns easier #20854
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obenland
added
[Type] Enhancement
A suggestion for improvement.
[Feature] Patterns
A collection of blocks that can be synced (previously reusable blocks) or unsynced
labels
Mar 12, 2020
Size Change: 0 B Total Size: 856 kB ℹ️ View Unchanged
|
Thanks for the PR. I agree with the goal. I think this API should be considered experimental and will definitely change before the final version though. (as the name of the property states) The PR is good though |
youknowriad
approved these changes
Mar 13, 2020
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] Patterns
A collection of blocks that can be synced (previously reusable blocks) or unsynced
[Type] Enhancement
A suggestion for improvement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Let's make it easier for plugins to add their own patterns to the stack. Filtering
block_editor_settings
at the default priority means that plugins will have to define a later priority to avoid having their patterns be overwritten. Not something they should have to worry about.__experimentalBlockPatterns
at priority 0Alternatively we could make the list of core patterns filterable:
How has this been tested?
Tested with a plugin that add its own patterns.
Types of changes
Enhancement to an existing feature
Checklist: