Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RNMobile]: Update 'Add Block Here' indicator style #20864

Merged
merged 1 commit into from
Mar 13, 2020
Merged

[RNMobile]: Update 'Add Block Here' indicator style #20864

merged 1 commit into from
Mar 13, 2020

Conversation

ceyhun
Copy link
Member

@ceyhun ceyhun commented Mar 13, 2020 •
edited
Loading

Description

Fixes: wordpress-mobile/gutenberg-mobile#1166

Gutenberg Mobile PR: wordpress-mobile/gutenberg-mobile#2014

How has this been tested?

  1. Tap (+) to insert a new block
  2. Check "ADD BLOCK HERE" design

Screenshots

Current

current

Proposed

Light
14-gray-margin-no-bold
Dark
14-gray-margin-no-bold-dark-mode

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@ceyhun ceyhun mentioned this pull request Mar 13, 2020
Merged
2 tasks
@Tug Tug self-requested a review March 13, 2020 10:00
Tug
Tug approved these changes Mar 13, 2020
View reviewed changes
Copy link
Contributor

@Tug Tug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@hypest
Copy link
Contributor

hypest commented Mar 13, 2020

The PR looks OK and approved so, will admin-merge.

@hypest hypest merged commit 4793696 into WordPress:master Mar 13, 2020
@github-actions github-actions bot added this to the Gutenberg 7.8 milestone Mar 13, 2020
@ceyhun ceyhun deleted the rnmobile/update-add-new-block-indicator-style branch March 13, 2020 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tug Tug Tug approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Gutenberg 7.8
Development

Successfully merging this pull request may close these issues.

Refine "Add new block" indicator style
3 participants
@ceyhun @hypest @Tug