Edit Post: Register block patterns as separate plugin #20871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcsf
added
[Type] Plugin Interoperability
youknowriad
reviewed
Mar 13, 2020
| @@ -16,11 +16,16 @@ import ToolsMoreMenuGroup from '../components/header/tools-more-menu-group'; | |||
| import WelcomeGuideMenuItem from './welcome-guide-menu-item'; | |||
| import BlockPatterns from './block-patterns'; | |||
|
|
|||
| registerPlugin( 'edit-post-block-patterns', { | |||
There was a problem hiding this comment.
maybe core/edit-post/block-patterns though I see that the other plugin doesn't respect this convention.
There was a problem hiding this comment.
Have you considered keeping it in its own module similar to Block Directory? This way you can prevent enqueueing the script when the experiment is disabled.
There was a problem hiding this comment.
That might make sense, if it allows us to keep patterns as a plugin even as we move it away from PluginSidebar, as long as we use the right kind of Slots to integrate patterns well.
youknowriad
approved these changes
Mar 13, 2020
|
Size Change: +9 B (0%) Total Size: 856 kB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Alternative to #20867.
Block Patterns are at an early stage of development and have so far been built as a sidebar plugin (#20354). This PR seeks to keep Patterns true to this design decision by ensuring they are registered as an independent plugin.
This, in turn, allows Block Patterns to be trivially disabled on any installation via the Plugins API:
This change should not condition planned improvements to Block Patterns that seek to make them an integral part of the editor (e.g. their inclusion in the Inserter).
How has this been tested?
Screenshots
Types of changes
Checklist: