-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code quality: Enable import/no-unresolved ESLint rule for Gutenberg #20905
Conversation
333a025
to
8bf8e43
Compare
Size Change: 0 B Total Size: 827 kB ℹ️ View Unchanged
|
Interesting, it fails on Travis on many WordPress dependencies. It works properly locally. There must be something related to |
That's strange. Those are imported from an That seems to fix it on my end, although I'm seeing a bunch of different errors on master, related to the icons and primitives packages |
@geriux do you mind taking over this one? |
Nice
Yes, sure go for it. Can you also move the whole component to the https://github.com/WordPress/gutenberg/tree/master/packages/components/src/mobile |
Yup! I'll do that 👍 thanks! |
I should give it a spin again after #22088 was merged. |
8bf8e43
to
ff22f4b
Compare
Description
Related to #15876.
I want to test this new rule against the Gutenberg repository before it gets enabled for the ESLint plugin.
How has this been tested?
npm run lint-js
Types of changes
Checklist: