Code quality: Enable import/no-unresolved ESLint rule for Gutenberg

[gziolo]

Description

Related to #15876.

I want to test this new rule against the Gutenberg repository before it gets enabled for the ESLint plugin.

How has this been tested?

npm run lint-js

Types of changes

Checklist:

• My code is tested.
• My code follows the WordPress code style.
• My code follows the accessibility standards.
• My code has proper inline documentation.
• I've included developer documentation if appropriate.
• I've updated all React Native files affected by any refactorings/renamings in this PR.

[github-actions]

Size Change: 0 B

Total Size: 827 kB

ℹ️ View Unchanged

Filename	Size	Change
build/a11y/index.js	1.02 kB	0 B
build/annotations/index.js	3.62 kB	0 B
build/api-fetch/index.js	4.08 kB	0 B
build/autop/index.js	2.82 kB	0 B
build/blob/index.js	620 B	0 B
build/block-directory/index.js	6.62 kB	0 B
build/block-directory/style-rtl.css	764 B	0 B
build/block-directory/style.css	764 B	0 B
build/block-editor/index.js	104 kB	0 B
build/block-editor/style-rtl.css	10.6 kB	0 B
build/block-editor/style.css	10.6 kB	0 B
build/block-library/editor-rtl.css	7.12 kB	0 B
build/block-library/editor.css	7.12 kB	0 B
build/block-library/index.js	115 kB	0 B
build/block-library/style-rtl.css	7.38 kB	0 B
build/block-library/style.css	7.38 kB	0 B
build/block-library/theme-rtl.css	683 B	0 B
build/block-library/theme.css	685 B	0 B
build/block-serialization-default-parser/index.js	1.88 kB	0 B
build/block-serialization-spec-parser/index.js	3.1 kB	0 B
build/blocks/index.js	48.1 kB	0 B
build/components/index.js	181 kB	0 B
build/components/style-rtl.css	17 kB	0 B
build/components/style.css	16.9 kB	0 B
build/compose/index.js	6.66 kB	0 B
build/core-data/index.js	11.4 kB	0 B
build/data-controls/index.js	1.29 kB	0 B
build/data/index.js	8.43 kB	0 B
build/date/index.js	5.47 kB	0 B
build/deprecated/index.js	772 B	0 B
build/dom-ready/index.js	568 B	0 B
build/dom/index.js	3.1 kB	0 B
build/edit-navigation/index.js	4.42 kB	0 B
build/edit-navigation/style-rtl.css	618 B	0 B
build/edit-navigation/style.css	617 B	0 B
build/edit-post/index.js	28 kB	0 B
build/edit-post/style-rtl.css	12.2 kB	0 B
build/edit-post/style.css	12.2 kB	0 B
build/edit-site/index.js	12.1 kB	0 B
build/edit-site/style-rtl.css	5.22 kB	0 B
build/edit-site/style.css	5.22 kB	0 B
build/edit-widgets/index.js	8.37 kB	0 B
build/edit-widgets/style-rtl.css	4.69 kB	0 B
build/edit-widgets/style.css	4.69 kB	0 B
build/editor/editor-styles-rtl.css	425 B	0 B
build/editor/editor-styles.css	428 B	0 B
build/editor/index.js	44.3 kB	0 B
build/editor/style-rtl.css	5.07 kB	0 B
build/editor/style.css	5.08 kB	0 B
build/element/index.js	4.65 kB	0 B
build/escape-html/index.js	734 B	0 B
build/format-library/index.js	7.63 kB	0 B
build/format-library/style-rtl.css	502 B	0 B
build/format-library/style.css	502 B	0 B
build/hooks/index.js	2.14 kB	0 B
build/html-entities/index.js	622 B	0 B
build/i18n/index.js	3.56 kB	0 B
build/is-shallow-equal/index.js	710 B	0 B
build/keyboard-shortcuts/index.js	2.51 kB	0 B
build/keycodes/index.js	1.94 kB	0 B
build/list-reusable-blocks/index.js	3.12 kB	0 B
build/list-reusable-blocks/style-rtl.css	226 B	0 B
build/list-reusable-blocks/style.css	226 B	0 B
build/media-utils/index.js	5.29 kB	0 B
build/notices/index.js	1.79 kB	0 B
build/nux/index.js	3.4 kB	0 B
build/nux/style-rtl.css	616 B	0 B
build/nux/style.css	613 B	0 B
build/plugins/index.js	2.56 kB	0 B
build/primitives/index.js	1.5 kB	0 B
build/priority-queue/index.js	789 B	0 B
build/redux-routine/index.js	2.85 kB	0 B
build/rich-text/index.js	14.8 kB	0 B
build/server-side-render/index.js	2.68 kB	0 B
build/shortcode/index.js	1.7 kB	0 B
build/token-list/index.js	1.28 kB	0 B
build/url/index.js	4.02 kB	0 B
build/viewport/index.js	1.84 kB	0 B
build/warning/index.js	1.14 kB	0 B
build/wordcount/index.js	1.18 kB	0 B

_{compressed-size-action}

[gziolo]

Interesting, it fails on Travis on many WordPress dependencies. It works properly locally. There must be something related to npm ci vs npm i or symlinks behave differently between macOS and Linux.

[koke]

I had to rename a few native files (page-template-picker was moved to mobile subfolder) to ensure it doesn't warn

That's strange. Those are imported from an index.native.js, and that one isn't a problem? I don't understand why moving those to mobile is fixing things, what I see is that page-template-picker/picker.js should probably be picker.native.js, and similarly for default-templates.js.

That seems to fix it on my end, although I'm seeing a bunch of different errors on master, related to the icons and primitives packages

[koke]

@geriux do you mind taking over this one?

[geriux]

I see is that page-template-picker/picker.js should probably be picker.native.js

Actually I already renamed that file in this merged PR

I can add .native to default-templates.js as well, does that work for you @gziolo ? Let me know either way =)

Thanks!

[gziolo]

I see is that page-template-picker/picker.js should probably be picker.native.js

Actually I already renamed that file in this merged PR

Nice

I can add .native to default-templates.js as well, does that work for you @gziolo ? Let me know either way =)

Yes, sure go for it. Can you also move the whole component to the mobile subfolder? It'd be the same pattern as used in here:

https://github.com/WordPress/gutenberg/tree/master/packages/components/src/mobile

[geriux]

Yes, sure go for it. Can you also move the whole component to the mobile subfolder? It'd be the same pattern as used in here:

Yup! I'll do that 👍 thanks!

[gziolo]

Interesting, it fails on Travis on many WordPress dependencies. It works properly locally. There must be something related to npm ci vs npm i or symlinks behave differently between macOS and Linux.

I should give it a spin again after #22088 was merged.