-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove inaccurate message from image block #20909
Remove inaccurate message from image block #20909
Conversation
package-lock.json
Outdated
@@ -19794,7 +19794,7 @@ | |||
}, | |||
"nopt": { | |||
"version": "4.0.1", | |||
"resolved": false, | |||
"resolved": "https://registry.npmjs.org/nopt/-/nopt-4.0.1.tgz", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the package-lock change is probably not needed in this PR, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the package-lock change is probably not needed in this PR, right?
yeah, right, this was made automatically, by "npm install" I guess.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to work as intended. Can we remove the package-lock changes and ship?
yeah, sure! |
Remove an inaccurate message from the image block, to make it the same as the other media files: audio and video. Fixes WordPress#20682
2996550
to
b06b2dd
Compare
Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Congrats for your first contribution. |
Description
Remove an inaccurate message from the image block, to make it the
same as the other media files: audio and video. Fixes #20682
How has this been tested?
npm run test
Screenshots
before:
after:
Checklist: