Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove inaccurate message from image block #20909

Merged
merged 1 commit into from
Mar 17, 2020
Merged

Remove inaccurate message from image block #20909

merged 1 commit into from
Mar 17, 2020

Conversation

aladin002dz
Copy link
Contributor

@aladin002dz aladin002dz commented Mar 15, 2020 •
edited
Loading

Description

Remove an inaccurate message from the image block, to make it the
same as the other media files: audio and video. Fixes #20682

How has this been tested?

npm run test

Screenshots

before:
before

after:
after

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

youknowriad
youknowriad reviewed Mar 16, 2020
View reviewed changes
package-lock.json Outdated
@@ -19794,7 +19794,7 @@
},
"nopt": {
"version": "4.0.1",
"resolved": false,
"resolved": "https://registry.npmjs.org/nopt/-/nopt-4.0.1.tgz",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the package-lock change is probably not needed in this PR, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the package-lock change is probably not needed in this PR, right?

yeah, right, this was made automatically, by "npm install" I guess.

youknowriad
youknowriad reviewed Mar 16, 2020
View reviewed changes
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to work as intended. Can we remove the package-lock changes and ship?

@aladin002dz
Copy link
Contributor Author

This seems to work as intended. Can we remove the package-lock changes and ship, sure!

This seems to work as intended. Can we remove the package-lock changes and ship?

yeah, sure!

@aladin002dz
Remove inaccurate message from image block
b06b2dd 
Remove an inaccurate message from the image block, to make it the
same as the other media files: audio and video. Fixes WordPress#20682
@aladin002dz aladin002dz force-pushed the fix/20682-image-block-message branch from 2996550 to b06b2dd Compare March 17, 2020 09:06
@aladin002dz
Copy link
Contributor Author

This seems to work as intended. Can we remove the package-lock changes and ship?

Done!
$ git pull upstream master (to reset all files and update local repo)
$ git checkout
$ git reset --hard HEAD^
remake change quickly, commit and push branch

youknowriad
youknowriad approved these changes Mar 17, 2020
View reviewed changes
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@youknowriad youknowriad merged commit 11eaaee into WordPress:master Mar 17, 2020
@youknowriad
Copy link
Contributor

Congrats for your first contribution.

@github-actions github-actions bot added this to the Gutenberg 7.8 milestone Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowriad youknowriad youknowriad approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@jorgefilipecosta jorgefilipecosta Awaiting requested review from jorgefilipecosta

@Soean Soean Awaiting requested review from Soean

@talldan talldan Awaiting requested review from talldan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Gutenberg 7.8
Development

Successfully merging this pull request may close these issues.

Contributor user sees inaccurate message in the image block type
2 participants
@aladin002dz @youknowriad