Make the inner button block not allowed as a reusable block or editable as HTML #20948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Bug
talldan
requested review from
ajitbohra,
jorgefilipecosta and
Soean
as code owners
|
Size Change: -102 B (0%) Total Size: 857 kB
ℹ️ View Unchanged
|
talldan
commented
Mar 17, 2020
| @@ -33,6 +33,8 @@ export const settings = { | |||
| supports: { | |||
| align: true, | |||
| alignWide: false, | |||
| reusable: false, | |||
| html: false, | |||
There was a problem hiding this comment.
It looks like this change affects mobile in the index.native.js file, so was wondering what the best way to update this setting on mobile would be (cc @pinarol)?
Is it best to keep the mobile setting as it currently is ... e.g.:
export const settings = {
...webSettings,
supports: {
align: true,
alignWide: false,
},
parent: undefined,
};
|
I agree with the reusable bit, but not sure about the edit as HTML. Why shouldn't that be possible? |
@mtias I noticed this was on other blocks with a parent, but it looks like I've made a bad assumption. It's specified on the Column block because of that being a parent block (#11785) and specified on the Navigation Link and Social Link blocks because those are dynamic blocks (#19483). So I've changed that again, the button can now be edited as html (74d3707). |
|
Great, thanks, that makes more sense. |
aduth
approved these changes
Mar 18, 2020
jorgefilipecosta
added
the
Backport to WP 6.7 Beta/RC
jorgefilipecosta
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #20942, which identifies that the button block can be made reusable, but then attempting to convert that reusable button block to a regular block outside of its parent context fails.
This PR makes the Button block consistent with other inner blocks (navigation link, social icons, column) with a distinct parent. Those blocks generally can't be made reusable, because of the above issue. They also generally can't be edited as HMTL. The general idea is that the parent has those options but the child doesn't.
With the Button block, there is a the possibility that this block is already in use in some reusable blocks and those still can't be converted to regular blocks, that's something this PR doesn't solve.
How has this been tested?
Screenshots
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: