Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use addQueryArgs() to build the oEmbed proxy URL #2097

Merged
merged 1 commit into from
Jul 31, 2017
Merged

Use addQueryArgs() to build the oEmbed proxy URL #2097

merged 1 commit into from
Jul 31, 2017

Conversation

dlh01
Copy link
Contributor

@dlh01 dlh01 commented Jul 31, 2017

See #2096.

@codecov
Copy link

codecov bot commented Jul 31, 2017 •
edited
Loading

Codecov Report

Merging #2097 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2097   +/-   ##
=======================================
  Coverage   20.25%   20.25%           
=======================================
  Files         135      135           
  Lines        4227     4227           
  Branches      718      718           
=======================================
  Hits          856      856           
  Misses       2842     2842           
  Partials      529      529
Impacted Files Coverage Δ
blocks/library/embed/index.js 45.97% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7e266c...c33347c. Read the comment docs.

@notnownikki notnownikki self-requested a review July 31, 2017 18:05
@notnownikki
Copy link
Member

Nice catch, thank you!

@notnownikki notnownikki merged commit e514290 into WordPress:master Jul 31, 2017
@westonruter westonruter mentioned this pull request Jul 31, 2017
Closed
2 tasks
@dlh01 dlh01 deleted the 2096-oembed-endpoint branch October 13, 2018 05:59
ceyhun pushed a commit that referenced this pull request Apr 22, 2020
@SergioEstevao
Merge pull request #2097 from wordpress-mobile/New-template-for-relea…
5018d2b 
…se-PRs

New template for release PRs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notnownikki notnownikki Awaiting requested review from notnownikki

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dlh01 @notnownikki