-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rnmobile/fix space max2 #20986
Merged
Merged
Rnmobile/fix space max2 #20986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergioEstevao
added
the
Mobile App - i.e. Android or iOS
Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
label
Mar 18, 2020
SergioEstevao
requested review from
ajitbohra,
jorgefilipecosta,
Soean and
talldan
as code owners
March 18, 2020 12:06
lukewalczak
approved these changes
Mar 18, 2020
This was referenced Mar 18, 2020
Size Change: +8 B (0%) Total Size: 857 kB
ℹ️ View Unchanged
|
7 tasks
marecar3
added a commit
that referenced
this pull request
Mar 18, 2020
* Disable Cover for production * Adapt max according to the current value. Co-authored-by: Marko Savic <savicmarko1985@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Mobile App - i.e. Android or iOS
Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix scenarios where the spacer height is larger than the current max and we want to allow users to edit the value inside the range.
How has this been tested?
This can be tested on GB mobile here: wordpress-mobile/gutenberg-mobile#2030
Screenshots
Types of changes
Checklist: