Update the heading block to use the colors hook #21039
Conversation
|
Size Change: +108 B (0%) Total Size: 856 kB
ℹ️ View Unchanged
|
| @@ -0,0 +1,13 @@ | |||
| h1, | |||
There was a problem hiding this comment.
The same question as for Paragraph block:
Are you sure it’s safe to set those values for all headings including front-end as part of the block definition?
The biggest limit is that you can only apply these styles/classnames to the block wrapper. I think it's probably enough for 90% of the cases. |
youknowriad
force-pushed
the
update/group-colors
branch
2 times, most recently
from
92ef4bb to
dfca58c
Compare
youknowriad
force-pushed
the
update/heading-colors
branch
from
b738c74 to
85cfb63
Compare
youknowriad
added
[Block] Heading
youknowriad
added
the
Needs Dev Note
youknowriad
requested review from
ajitbohra,
ellatrix,
jorgefilipecosta,
nerrad,
ntwb,
Soean and
talldan
as code owners
youknowriad
force-pushed
the
update/heading-colors
branch
from
85cfb63 to
43ef782
Compare
|
It needs to be rebased with master. I see changes from the parent PR in here that makes the final call harder |
|
@gziolo it should be better now, the base branch was wrong. |
There was a problem hiding this comment.
Overall it's good to go. Nice work!
Depending on how the proposal from @nosolosw shared in #21037 (comment) ends up implemented, CSS code added in this PR should be updated. I guess it's fine to merge and update later.
youknowriad
force-pushed
the
update/heading-colors
branch
from
43ef782 to
f38d42b
Compare
|
Is Heading background color UI being added or is it just that it is implemented but not added through the UI? It would be good to add the Heading background UI control while your first working with this...:) |
|
it's added in the UI |
| }; | ||
|
|
||
| const deprecated = [ | ||
| { | ||
| attributes: blockAttributes, | ||
| supports: blockSupports, |
There was a problem hiding this comment.
I forgot about one thing, it would be nice to add the test case that covers this new deprecation:
- a block that has
has-text-colorclass set?
@jorgefilipecosta should know best what's the snippet that makes this deprecation unique.
There was a problem hiding this comment.
I will look into the deprecations and try to add a snippet specific for this deprecation 👍
youknowriad
removed
the
Needs Dev Note
Based on #21021 to try test the API on different blocks (heading for this PR)
It also adds background color support to the heading block. At the moment there's no way to choose just text color, but it's easy to implement if needed. I just thought being consistent with other blocks is a good thing.