-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Components: Text - Slight refactor and exports as experimental #21088
Conversation
@@ -80,6 +80,7 @@ export { default as Snackbar } from './snackbar'; | |||
export { default as SnackbarList } from './snackbar/list'; | |||
export { default as Spinner } from './spinner'; | |||
export { default as TabPanel } from './tab-panel'; | |||
export { default as __experimentalText } from './text'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is
export * from './text';
in the last line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh! I missed that. I'll update that.
I think this update feels more inline with how we've been exporting our other components 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that the proposed changes make sense 👍
Size Change: -1.16 kB (0%) Total Size: 859 kB
ℹ️ View Unchanged
|
@gziolo I've merged in the latest cc'ing @SergioEstevao to double check (👋 hai!!!) Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the refactor on GB mobile and it's working fine.
I think this component is neat and I wanted to use it in a custom block because I found it in the live Block Editor Handbook: https://developer.wordpress.org/block-editor/components/text/ However, this live documentation makes no mention of this being an
is really meant to be
and thus is probably not ready for prime time, AKA live in the public Block Handbook docs. |
Description
This update refactors the (experimental)
Text
primitive and exports the component as__experimentalText
from@wordpress/components
How has this been tested?
Types of changes
Text
component as__experimentalText
incomponents/src/index.js
Checklist:
Resolves: #21084