Components: Text - Slight refactor and exports as experimental #21088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ItsJonQ
requested review from
ajitbohra,
chrisvanpatten,
jorgefilipecosta and
youknowriad
as code owners
gziolo
reviewed
Mar 23, 2020
| @@ -80,6 +80,7 @@ export { default as Snackbar } from './snackbar'; | |||
| export { default as SnackbarList } from './snackbar/list'; | |||
| export { default as Spinner } from './spinner'; | |||
| export { default as TabPanel } from './tab-panel'; | |||
| export { default as __experimentalText } from './text'; | |||
There was a problem hiding this comment.
There is
export * from './text';
in the last line.
There was a problem hiding this comment.
Oh! I missed that. I'll update that.
I think this update feels more inline with how we've been exporting our other components 🙏
There was a problem hiding this comment.
I agree that the proposed changes make sense 👍
|
Size Change: -1.16 kB (0%) Total Size: 859 kB
ℹ️ View Unchanged
|
6 tasks
|
@gziolo I've merged in the latest cc'ing @SergioEstevao to double check (👋 hai!!!) Thank you! |
SergioEstevao
approved these changes
Mar 26, 2020
|
I think this component is neat and I wanted to use it in a custom block because I found it in the live Block Editor Handbook: https://developer.wordpress.org/block-editor/components/text/ However, this live documentation makes no mention of this being an is really meant to be and thus is probably not ready for prime time, AKA live in the public Block Handbook docs. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This update refactors the (experimental)
Textprimitive and exports the component as__experimentalTextfrom@wordpress/componentsHow has this been tested?
Types of changes
Textcomponent as__experimentalTextincomponents/src/index.jsChecklist:
Resolves: #21084