IE11: fix focus on backspace #21092
Merged
IE11: fix focus on backspace #21092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
[Type] Bug
|
Size Change: -16 B (0%) Total Size: 859 kB
ℹ️ View Unchanged
|
aduth
approved these changes
Mar 23, 2020
There was a problem hiding this comment.
Tested various interactions of merging and splitting paragraphs. Works well in Internet Explorer. Verified in my main browser (Chrome) as well, but I expect the end-to-end test coverage here is pretty thorough. Just in case, I also ran through these behaviors in Firefox and Safari.
I might still be curious based on what was discussed at #20594 (comment) if there is a hypothetical edge case to consider, but for the purposes of resolving the immediate issue, this appears to work well.
|
Yes, I do wonder in which cases we're leaving focus on the editable element, when focus couldn't be set back to the previous element. Let's explore that separately when there is time. |
jorgefilipecosta
added
the
Backport to WP 6.7 Beta/RC
jorgefilipecosta
pushed a commit
that referenced
this pull request
Mar 23, 2020
jorgefilipecosta
pushed a commit
that referenced
this pull request
Mar 23, 2020
jorgefilipecosta
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #20598. Introduced in #20594.
How has this been tested?
See #20598. Needs testing in IE11.
Screenshots
Types of changes
Checklist: